Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for .env file to safely store secret key #196

Open
jxdv opened this issue May 24, 2024 · 1 comment · May be fixed by #204
Open

feat: add support for .env file to safely store secret key #196

jxdv opened this issue May 24, 2024 · 1 comment · May be fixed by #204
Assignees
@jxdv
Labels
enhancement Improved something about the project feature New feature for the project good first issue Good for newcomers

Comments

@jxdv
Copy link
Member

jxdv commented May 24, 2024

Describe the feature you want

Use python-dotenv to store secrets in order to avoid bad practice, such as hardcoding secrets into the source code.

Describe the problem your feature is related to

Currently gX hardcodes a Flask secret key in the source code. It would be a good idea to add support for .env file where the secret key will be stored. If the secret key can't be loaded from the .env file then log an error and don't allow the user to start the Web UI.
@jxdv jxdv added enhancement Improved something about the project feature New feature for the project labels May 24, 2024
@jxdv jxdv self-assigned this May 24, 2024
@orhun orhun added the good first issue Good for newcomers label May 24, 2024
@orhun
Copy link
Member

orhun commented May 24, 2024

Would be nice to have this!

@jxdv jxdv mentioned this issue May 25, 2024
Closed
@jxdv jxdv linked a pull request Jun 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jxdv jxdv

Labels
enhancement Improved something about the project feature New feature for the project good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@orhun @jxdv