Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release 2.0.0 #46

Closed
tancnle opened this issue Jan 29, 2024 · 12 comments
Closed

New release 2.0.0 #46

tancnle opened this issue Jan 29, 2024 · 12 comments

Comments

@tancnle
Copy link
Contributor

tancnle commented Jan 29, 2024

@grantjenks Would it be possible to push a new release of tree_sitter_languages?

Many thanks for your work on this project.

@grantjenks
Copy link
Owner

Release triggered at https://github.com/grantjenks/py-tree-sitter-languages/actions/runs/7706777756

@tancnle
Copy link
Contributor Author

tancnle commented Jan 30, 2024

Thank you for pushing a new release @grantjenks 🙇🏼

I have noticed that macOS and windows wheels are not available on PyPi. I can see the macOS build was completed successfully but the subsequent upload job did not include them 🤔

@tancnle
Copy link
Contributor Author

tancnle commented Jan 30, 2024

@tancnle
Copy link
Contributor Author

tancnle commented Jan 30, 2024

I think both macOS and windows artefacts are overwritten by ubuntu ones because of this change bc2ba52.

@tancnle
Copy link
Contributor Author

tancnle commented Jan 30, 2024

I think reverting back to upload-artifact@v2 would be a quickest fix (#47)

@grantjenks
Copy link
Owner

@tancnle
Copy link
Contributor Author

tancnle commented Jan 31, 2024

@grantjenks It seems that the build is failing due to artefacts not being found. I think it is due to some compatibility issue between upload-artifact@v2 and download-artifact@v4. 🤔

I have reinstated upload-artifact@v4 (PR) and ensured there are no naming conflicts (following the example from upload-artifact repo). The artefact links are shown up in the log (source).

Screenshot 2024-01-31 at 10 59 20 pm

Hopefully, the upload job will pass this time. Could you kindly have another look? 🙏🏼

@andreportela
Copy link

How can I test it on macOS M1?

@tancnle
Copy link
Contributor Author

tancnle commented Feb 1, 2024

@andreportela We need to push a new release so the package with MacOS wheels will be available via PyPi. At the moment, you can download the wheels directly from the artefacts page.

  1. Download wheelhouse-macos-latest and unpack the locally.

  2. Select the appropriate one for your Python version and arch. For example, I use Python 3.11 on M1 so I select tree_sitter_languages-1.10.1-cp311-cp311-macosx_11_0_arm64.whl.

    ./
    tree_sitter_languages-1.10.1-cp310-cp310-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp310-cp310-macosx_11_0_arm64.whl
    tree_sitter_languages-1.10.1-cp311-cp311-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp311-cp311-macosx_11_0_arm64.whl
    tree_sitter_languages-1.10.1-cp312-cp312-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp312-cp312-macosx_11_0_arm64.whl
    tree_sitter_languages-1.10.1-cp37-cp37m-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp38-cp38-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp38-cp38-macosx_11_0_arm64.whl
    tree_sitter_languages-1.10.1-cp39-cp39-macosx_10_9_x86_64.whl
    tree_sitter_languages-1.10.1-cp39-cp39-macosx_11_0_arm64.whl
  3. Install the package

    ❯ pip install tree_sitter_languages-1.10.1-cp311-cp311-macosx_11_0_arm64.whl 
  4. Try it out

    $ python
    Python 3.11.7 (main, Jan 15 2024, 18:10:15) [Clang 15.0.0 (clang-1500.1.0.2.5)] on darwin
    Type "help", "copyright", "credits" or "license" for more information.
    >>> from tree_sitter_languages import get_language, get_parser
    >>> language = get_language('python')
    >>>> parser = get_parser('python')

@tancnle
Copy link
Contributor Author

tancnle commented Feb 1, 2024

👋🏼 @grantjenks would it be possible if you could please push another release or perhaps rebuild/push 1.10.1 🙏🏼?

@grantjenks
Copy link
Owner

Try 2: https://github.com/grantjenks/py-tree-sitter-languages/actions/runs/7772134775

@tancnle
Copy link
Contributor Author

tancnle commented Feb 6, 2024

Thanks @grantjenks. The new package looks good to me 🙇🏼‍♂️

@tancnle tancnle closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants