fix(build): Update build and CI workflows #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 seconds is too short for running tests on my local machine and now it timed out on Github actions as well.
matrei
force-pushed
the
matrei/longer-test-timeout
branch
from
4ef9fb5
to
e30c988
Compare
matrei
changed the title
CI fails with `Failed to download graalvm-ce-java11-darwin-aarch64-21.3.3.1. Are you sure version: '21.3.3.1' and java-version: '11' are correct?`. This commit is an attempt to fix that.
CI fails building GraalVM native images. This commit is a first step trying to fix this by updating the workflow files to latest standards: - wrapper-validation - gradle/actions/setup-gradle@v3 (with temurin) - run ./gradlew instead of setup-gradle->with->arguments - remove patch and minor release versions from imported actions
2 of 3 platforms compiled successfully with this version. More changes seems to be needed to upgrade. Reverting to it for now.
- Updated action versions - Removed the wrapper validator as that is built into `gradle/actions/setup-gradle` - Removed the version parameter to `graalvm/setup-graalvm` as this failed for OS X: Error: Failed to download graalvm-ce-java11-darwin-aarch64-21.3.3.1. Are you sure version: '21.3.3.1' and java-version: '11' are correct?
- Update to run on Java 17 - Update `setup-gradle` to v4 - `wrapper-validation` not needed as it is run by `setup-gradle` - No token needed for `checkout`
- Use quotes and emojis for readability - Remove redundant logic and steps from `release-notes.yml` - Use multi-line run commands for readability - Change git user and email to 'grails-build' account - Update `stefanzweifel/git-auto-commit-action` to 5.0.1 - Use `musl` for Linux native image - Change from `native-image` to `gradle nativeCompile` - Add OS X Arm Native CLI
matrei
force-pushed
the
matrei/longer-test-timeout
branch
5 times, most recently
from
426d566
to
316f477
Compare
Add `org.graalvm.buildtools.native` Gradle plugin for nativeCompile task.
matrei
force-pushed
the
matrei/longer-test-timeout
branch
from
316f477
to
223852f
Compare
matrei
changed the title
sdelamo
approved these changes
Aug 9, 2024
| - name: Set up JDK | ||
| uses: actions/[email protected] | ||
| - name: "☕️ Setup JDK" | ||
| uses: actions/setup-java@v4 |
There was a problem hiding this comment.
Not sure about using @v4 instead of the exact version with @v4.2.1. I had seen issues with GitHub actions updating and breaking builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the project build and CI workflows to a succeeding state.
It also adds generation of a OS X Arm CLI.