Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestPageTargetBlank fails by waitForEvent timeout #1506

Open
2 tasks
inancgumus opened this issue Nov 4, 2024 · 0 comments
Open
2 tasks

TestPageTargetBlank fails by waitForEvent timeout #1506

inancgumus opened this issue Nov 4, 2024 · 0 comments
Labels
bug Something isn't working tests

Comments

@inancgumus
Copy link
Member

inancgumus commented Nov 4, 2024 •
edited
Loading

What?

TestPageTargetBlank is flaky.

--- FAIL: TestPageTargetBlank (33.39s)
    page_test.go:1826: 
                Error Trace:    /Users/inanc/grafana/k6browser/main/tests/page_test.go:1826
                Error:          Received unexpected error:
                                waitForEvent timed out after 30s
                Test:           TestPageTargetBlank

Why?

  • Makes it difficult to run the tests consistently.
  • It might indicate an underlying issue with WaitForEvent method.

How?

Module version: 1.9.1

Tasks

Tasks
Preview Give feedback

Related PR(s)/Issue(s)
@inancgumus inancgumus added bug Something isn't working tests labels Nov 4, 2024
inancgumus added a commit that referenced this issue Nov 6, 2024
@inancgumus
Fix TestKeyboardPress panic
dd098ed 
This only fixes the panic, but not the underlying error with
WaitForEvent. There is clearly an issue with WaitForEvent as we can
also see in #1506.
@inancgumus inancgumus mentioned this issue Nov 6, 2024
Merged
3 tasks
inancgumus added a commit that referenced this issue Nov 7, 2024
@inancgumus
Fix TestKeyboardPress panic
17a865f 
This only fixes the panic, but not the underlying error with
WaitForEvent. There is clearly an issue with WaitForEvent as we can
also see in #1506.
inancgumus added a commit that referenced this issue Nov 7, 2024
@inancgumus
Fix TestKeyboardPress panic
151b982 
This only fixes the panic, but not the underlying error with
WaitForEvent. There is clearly an issue with WaitForEvent as we can
also see in #1506.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inancgumus