Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss: Should we add option parsing to the trace spans? #4225

Open
Tracked by #4219
inancgumus opened this issue Jul 1, 2024 · 0 comments
Open
Tracked by #4219

Discuss: Should we add option parsing to the trace spans? #4225

inancgumus opened this issue Jul 1, 2024 · 0 comments
Labels
area: browser

Comments

@inancgumus
Copy link
Member

inancgumus commented Jul 1, 2024 •
edited
Loading

What?

In grafana/xk6-browser#1389, we desobekify Browser but lose the option parsing trace span error. Questions

  • Should we start the span in the mapping layer instead?
  • Should we ever include the option parsing errors in the spans?

Why?

To decide whether to use lose the option parsing spans.

How?

No response

Related PR(s)/Issue(s)

#4219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: browser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inancgumus