-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch in count of OTel attributes to index and default label limit #12913
Comments
Maybe the idea was that all attributes will never be used at once? (Deployment / StatefulSet / DaemonSet / ...) If so, this issue is just reporting the old default limit (30) in:
|
Yeah, not all attributes will be set at once. Some of them are mutually exclusive.
Yeah, it was a mistake. I think I referenced the old limit, which was 30 earlier. Thanks for pointing it out! I will fix it. |
Describe the bug
The count of OTel attributes to index (17) and the default label limit (15) do not match:
loki/docs/sources/shared/configuration.md
Lines 2008 to 2011 in 19fef93
loki/docs/sources/shared/configuration.md
Lines 2896 to 2898 in 19fef93
The 17 OTel resource attributes are also listed in the docs, which mentions the old default limit (
max_label_names_per_series: 30
):loki/docs/sources/send-data/otel/_index.md
Lines 75 to 92 in 19fef93
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The count of attributes and labels match.
Environment:
Screenshots, Promtail config, or terminal output
Comment
I would have created a PR to fix the docs, but I suspect this might lead to a default config change?
The text was updated successfully, but these errors were encountered: