Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted initVersion to ensure a clean semver version is used #1389

Closed
wants to merge 1 commit into from

Conversation

sebvautour
Copy link

Hi @alexanderzobnin,

This PR fixes an issue where an invalid version error is returned if the Zabbix API returns the semver plus a date.

Related issue: #1385

Copy link
Contributor

@Sam-H101 Sam-H101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what will happen if version is null? I would personally move this into the if statement to confirm there is a version to semver.clean first.

I think that works anyways. Cant 100% remember as not to familiar with the language.

if (version) {
version = semver.clean(version);
console.log.....

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


svautour seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ivanahuckova
Copy link
Member

Hi sebvautour and thank you for contribution. The code has changed a lot since. If the issue still happens, please could you open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants