New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use static/info_arch.json
as source for components for primer/view_components
#3
Comments
@gr2m it looks like at least one component is in there twice, probably because of the status namespacing, eg |
Shouldn't hurt to keep them, consumers just wouldn't subscribe to them. I'd prefer not to add extra logic to the parsing.
Should we use the fully qualified names instead? I assume the fully qualified name are also what is used in Ruby code when importing them? So e.g. |
👍
Yes please |
…nfo_arch.json as source for View Components (#4) closes #3
🎉 This issue has been resolved in version 2.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
follow up to primer/view_components#2038 (comment)
At first glance,
static/info_arch.json
return 76 componentsWhile https://primer.github.io/view_components/components.json only returns 69
Also the capitalization is different
The text was updated successfully, but these errors were encountered: