Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to allow merging from forks #86

Open
IstoraMandiri opened this issue Jun 19, 2023 · 1 comment
Open

Option to allow merging from forks #86

IstoraMandiri opened this issue Jun 19, 2023 · 1 comment

Comments

@IstoraMandiri
Copy link

In #6, all PRs from forked repos are ignored.

It is understandable to ignore forked repos by default, but in the following case, shouldn't this be allowed?

If the target branch is protected and requires maintainer approval(s) for merging, it can be assumed that the PR, once approved, is safe to merge and should be allowed to be scheduled whether or not it's from a forked repo.

@gr2m
Copy link
Owner

gr2m commented Jun 20, 2023

I'm still afraid this might cause unwanted merges.

I'd be okay to turn this into an option that makes explicit how dangerous it is, something like a dangerously_enable_merges_from_forks option, and even then I'd check if branch protections are enabled.

If you or someone else wants to work on it, make sure to update docs and add tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants