Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test fail when a request changes #81

Open
gr2m opened this issue Oct 24, 2022 · 0 comments
Open

Make test fail when a request changes #81

gr2m opened this issue Oct 24, 2022 · 0 comments

Comments

@gr2m
Copy link
Owner

gr2m commented Oct 24, 2022

This is a follow up to #80 /cc @tmelliottjr

In #80 we changed the way field values are unset, by using a new mutation instead of setting the value to "". We expected the existing test to unset a text field would fail as the implementation changed, but it didn't. We agreed that it would be good if it would fail, so that updating the recorded fixtures would be necessary explicitly in a situation like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant