Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird language fallback in countries.rq #481

Open
Abbe98 opened this issue Jan 3, 2025 · 0 comments
Open

Weird language fallback in countries.rq #481

Abbe98 opened this issue Jan 3, 2025 · 0 comments
Labels
bug 🐛 Something isn't working

Comments

@Abbe98
Copy link
Member

Abbe98 commented Jan 3, 2025

What happened?

Following up on the discussion in #472.

The language fallback in the country generic query countries.rq can result in unexpected labels, on the other hand it makes it less likely for us to display an identifier.

Some thoughts:

  • Can we make the query somehow less label dependent
  • Make the query more complex using sub queries and store language fallbacks per country (terrible idea)
  • In case we do end up with a QID ensure it displays in a more informative (we should probably do this across GD anyway)
  • Write a test that checks that countries.rq do return sane en/mul labels (the easiest?)

What browsers are you seeing the problem on?

No response

@Abbe98 Abbe98 added the bug 🐛 Something isn't working label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant