Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT token not cleared out from axios headers on logout #296

Open
Gerfaut opened this issue Jan 3, 2020 · 2 comments
Open

JWT token not cleared out from axios headers on logout #296

Gerfaut opened this issue Jan 3, 2020 · 2 comments

Comments

@Gerfaut
Copy link

Gerfaut commented Jan 3, 2020

Hello,
I noticed that the Authorization header (containing the JWT token) is still present on the next calls just after the logout.

Here are the step to reproduce :

  • Login with an existing user ;
  • Navigate to produce a call to backend -> the Authorization header is set : OK.
  • Go to settings and Logout -> The token is destroyed from the localStorage : OK.
  • Don't refresh/reload the page your browser.
  • Navigate to produce a call to backend -> the Authorization header is set : NOK.

The headers should be discarded / cleaned out after logout.
As the actions are disabled when the currentUser is not set (and that's correctly done on logout), the impact is low, but this stays quite unsecure.

Thanks a lot for this great example project!

Gerfaut

@erwinant
Copy link

erwinant commented May 5, 2020

Hi, i was wondering, i see there is not validating token for every API endpoint. Are u only check user for every load the route?

@thinh105
Copy link

thinh105 commented Jul 22, 2020

Look like it is a bug,

The Authorization header still contains the token, I saw the code and see no action to clean that,

Test on https://vue-vuex-realworld.netlify.com/

So when we log out,
just visit https://vue-vuex-realworld.netlify.com/#/settings and change something
~> Click Update settings
~> Vola, you can change it, and also automatically login!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants