Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing the documentation hyperlink to doc.go #97

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

apoorvajagtap
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

After a quick gothrough, it seems redirecting to the actually Documentation available on pkg.go.dev (https://github.com/gorilla/rpc/blob/main/doc.go) could help in eliminating the infinite loop.

If this suits as considerable idea, I'll update it for rest of the modules too (ref: #85 (comment)).

Related Tickets & Documents

Added/updated tests?

  • Yes
  • No, just a doc update
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3a1155) 71.44% compared to head (ef1c5b7) 71.44%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   71.44%   71.44%           
=======================================
  Files          15       15           
  Lines         844      844           
=======================================
  Hits          603      603           
  Misses        181      181           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaitaiwan jaitaiwan merged commit 39123e3 into gorilla:main Feb 10, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants