Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to downgrade mod #330

Closed
T3sT3ro opened this issue May 26, 2023 · 4 comments
Closed

Option to downgrade mod #330

T3sT3ro opened this issue May 26, 2023 · 4 comments
Labels
enhancement Improvements to the project

Comments

@T3sT3ro
Copy link

T3sT3ro commented May 26, 2023

The Problem

I didn't find that it's possible right now, but downgrading versions would be useful. Currently I am in a situation where the most recent sodium version is bugged and I gave to downgrade, but can't see that ferium uption: CaffeineMC/sodium-fabric#1778

This relates to #82, because downgraded mods would have to be pinned and displayed differently on mod list.

Your Solution(s)

Instead of removing the mod from list and having to add it to user/, a version pinning option that can be toggled for mods, an interactive selector for version of mod and a patch to updater where pinned versions are skipped.

@T3sT3ro T3sT3ro added the enhancement Improvements to the project label May 26, 2023
@derspyy
Copy link

derspyy commented May 26, 2023

the latest sodium on modrinth is 0.4.10. so running ferium upgrade should use that. is that not the case?

@T3sT3ro
Copy link
Author

T3sT3ro commented May 26, 2023

hmm, You are right, I do have sodium 0.4.10 pulled. Nonetheless, an option to downgrade and pin a mod would be nice (because earlier sodium 0.4.11 was present, and mod author removed the most recent version it was OK; if, however, author didn't remove the problematic version or it took some time, then ferium would pull the most recent, broken version).

For example I currently have sodium 0.4.10 pulled, but I have the most recent "Sodium Extra" (sodium-extra-0.4.19+mc1.19.3-build.101.jar) present as well, which depends on 0.4.11. Although the most recent stable version for Sodium Extra is 0.4.18 it pulled the (now alpha, idk if it was marked "stable" before) the 0.4.19 version and doesn't want to downgrade properly when using ferium upgrade. I even removed and added this mod again with ferium remove/add and it still pull alpha channel???

@theRookieCoder
Copy link
Collaborator

The Sodium Extra issue specifically would be fixed by either #82 or #196

Duplicate of #82. Just curious, but why did you decide to create this issue even if you knew this relates to #82 anyways?

@theRookieCoder theRookieCoder closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2023
@T3sT3ro
Copy link
Author

T3sT3ro commented May 27, 2023

Hmm, probably a momentary brainfart 😅 I was thinking about "mod pinning" as a way to tell ferium "stop updating this mod untill unpinned". In here I was thinking about a subcommand that displays an interactive list of all compatible versions and lets user select one to pin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the project
Development

No branches or pull requests

3 participants