Add maxCommandLen setting and SetMaxCommandLen function

Author: outdead

.golangci.yml

@@ -132,9 +132,6 @@ linters-settings:
 linters:
   enable-all: true
   disable:
-    - rowserrcheck # is disabled because of generics
-    - sqlclosecheck # is disabled because of generics
-    - wastedassign # is disabled because of generics
     - exportloopref # is deprecated (since v1.60.2)
     - dupword
     - wrapcheck
@@ -144,10 +141,9 @@ linters:
 
 issues:
   exclude:
-    - "don't use ALL_CAPS in Go names; use CamelCase" # golint
+    - "don't use ALL_CAPS in Go names; use CamelCase" # revive
     - "ST1003: should not use ALL_CAPS in Go names; use CamelCase instead" # stylecheck
     - "DefaultSettings`? is a global variable" # gochecknoglobals
-    - "are|is missing in" # exhaustivestruct # v1.33
   exclude-dirs:
     - vendor/
   exclude-files:

CHANGELOG.md

@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
 **ATTN**: This project uses [semantic versioning](http://semver.org/).
 
 ## [Unreleased]
+### Added
+- Added maxCommandLen setting and SetMaxCommandLen function.
 
 ## [v1.4.0] - 2024-11-16
 ### Fixed

option.go

@@ -4,14 +4,16 @@ import "time"
 
 // Settings contains option to Conn.
 type Settings struct {
-	dialTimeout time.Duration
-	deadline    time.Duration
+	dialTimeout   time.Duration
+	deadline      time.Duration
+	maxCommandLen int
 }
 
 // DefaultSettings provides default deadline settings to Conn.
 var DefaultSettings = Settings{
-	dialTimeout: DefaultDialTimeout,
-	deadline:    DefaultDeadline,
+	dialTimeout:   DefaultDialTimeout,
+	deadline:      DefaultDeadline,
+	maxCommandLen: DefaultMaxCommandLen,
 }
 
 // Option allows to inject settings to Settings.
@@ -30,3 +32,10 @@ func SetDeadline(timeout time.Duration) Option {
 		s.deadline = timeout
 	}
 }
+
+// SetMaxCommandLen injects maxCommandLen to Settings.
+func SetMaxCommandLen(maxCommandLen int) Option {
+	return func(s *Settings) {
+		s.maxCommandLen = maxCommandLen
+	}
+}

rcon.go

@@ -17,9 +17,9 @@ const (
 	// DefaultDeadline provides default deadline to tcp read/write operations.
 	DefaultDeadline = 5 * time.Second
 
-	// MaxCommandLen is an artificial restriction, but it will help in case of random
+	// DefaultMaxCommandLen is an artificial restriction, but it will help in case of random
 	// large queries.
-	MaxCommandLen = 1000
+	DefaultMaxCommandLen = 1000
 
 	// SERVERDATA_AUTH is the first packet sent by the client,
 	// which is used to authenticate the conn with the server.
@@ -148,7 +148,7 @@ func (c *Conn) Execute(command string) (string, error) {
 		return "", ErrCommandEmpty
 	}
 
-	if len(command) > MaxCommandLen {
+	if c.settings.maxCommandLen > 0 && len(command) > c.settings.maxCommandLen {
 		return "", ErrCommandTooLong
 	}