fix: [#528] GraphQL request causing errors from request body parsing (#107)

Author: hwbrzzl

context_request.go

@@ -34,7 +34,7 @@ type ContextRequest struct {
 func NewContextRequest(ctx *Context, log log.Log, validation contractsvalidate.Validation) contractshttp.ContextRequest {
 	postData, err := getPostData(ctx)
 	if err != nil {
-		LogFacade.Error(fmt.Sprintf("%+v", errors.Unwrap(err)))
+		LogFacade.Error(fmt.Sprintf("%+v", err))
 	}
 
 	return &ContextRequest{ctx: ctx, instance: ctx.instance, postData: postData, log: log, validation: validation}
@@ -472,11 +472,13 @@ func getPostData(ctx *Context) (map[string]any, error) {
 			return nil, fmt.Errorf("retrieve json error: %v", err)
 		}
 
-		if err := json.Unmarshal(bodyBytes, &data); err != nil {
-			return nil, fmt.Errorf("decode json [%v] error: %v", string(bodyBytes), err)
-		}
+		if len(bodyBytes) > 0 {
+			if err := json.Unmarshal(bodyBytes, &data); err != nil {
+				return nil, fmt.Errorf("decode json [%v] error: %v", string(bodyBytes), err)
+			}
 
-		request.Body = io.NopCloser(bytes.NewBuffer(bodyBytes))
+			request.Body = io.NopCloser(bytes.NewBuffer(bodyBytes))
+		}
 	}
 
 	if contentType == "multipart/form-data" {

context_request_test.go

@@ -983,6 +983,26 @@ func (s *ContextRequestSuite) TestInputBool() {
 	s.Equal(http.StatusOK, code)
 }
 
+// Test Issue: https://github.com/goravel/goravel/issues/528
+func (s *ContextRequestSuite) TestPostWithEmpty() {
+	s.route.Post("/post-with-empty", func(ctx contractshttp.Context) contractshttp.Response {
+		return ctx.Response().Success().Json(contractshttp.Json{
+			"all": ctx.Request().All(),
+		})
+	})
+
+	payload := strings.NewReader("")
+	req, err := http.NewRequest("POST", "/post-with-empty?a=1", payload)
+	req.ContentLength = 1
+	s.Require().Nil(err)
+
+	req.Header.Set("Content-Type", "application/json")
+	code, body, _, _ := s.request(req)
+
+	s.Equal("{\"all\":{\"a\":\"1\"}}", body)
+	s.Equal(http.StatusOK, code)
+}
+
 func (s *ContextRequestSuite) TestQuery() {
 	s.route.Get("/query", func(ctx contractshttp.Context) contractshttp.Response {
 		return ctx.Response().Success().Json(contractshttp.Json{