Skip to content

Commit 48444c3

Browse files
committed
Merge with updated DLH
1 parent c76041f commit 48444c3

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/config/configProcessors.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,8 @@ function configProcessors(helper, eventProcessor, eventOptions,
150150
function processEvent(name, options = undefined) {
151151
const model = this;
152152
if (!options) options = {};
153-
options = merge(getExtraOptions(helper, processor), eventOptions, options);
153+
options = merge(getExtraOptions(helper, processor.constructor),
154+
eventOptions, options);
154155
processor.processEvent(/** @type {!StorageInterface} */(storage),
155156
model, name, options);
156157
}

src/config/setup.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,10 @@ function setupMeasure(dataLayer) {
3030
const helper = new DataLayerHelper(dataLayer, {'processNow': false});
3131

3232
helper.registerProcessor('config',
33-
(eventProcessor, eventOptions, storageProcessor, storageOptions) =>
33+
(eventProcessor, eventOptions, storageProcessor, storageOptions) => {
3434
configProcessors(helper, eventProcessor, eventOptions,
35-
storageProcessor, storageOptions));
35+
storageProcessor, storageOptions);
36+
});
3637
helper.process();
3738
}
3839

test/unit/config/processEvent_test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ describe('After calling measure with `event` as the first parameter', () => {
4545

4646

4747
describe('The call forwarded after a call to measure(`event`, ...)', () => {
48-
/* TODO:(wolfblue@): Fix the issue here, it stems from data layer helper
4948
it('inherits any parameters from set called before the constructor',
5049
() => {
5150
measure('set', 'processor', {'cat': 'meow'});
@@ -69,7 +68,6 @@ describe('After calling measure with `event` as the first parameter', () => {
6968
set: jasmine.any(Function),
7069
}, 'name', {'cat': 'meow', 'dog': 'woof'});
7170
});
72-
*/
7371

7472
it('does not inherit if set is called unscoped', () => {
7573
measure('config', MockProcessor, {'dog': 'woof'}, MockStorage, {});

0 commit comments

Comments
 (0)