Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Firefox addon #2

Open
domoritz opened this issue Nov 4, 2018 · 6 comments
Open

Publish Firefox addon #2

domoritz opened this issue Nov 4, 2018 · 6 comments

Comments

@domoritz
Copy link

domoritz commented Nov 4, 2018

Since this is a webextension, the same code should work as a Firefox add-on.

@electron0zero
Copy link

I forked and fixed some firefox related warnings and published it: https://addons.mozilla.org/en-US/firefox/addon/open-in-colab/

Source: https://github.com/electron0zero/open_in_colab

@domoritz
Copy link
Author

domoritz commented Nov 5, 2018

Do you want to send a PR to merge the changes into here? I think it would make sense to set browser as const browser = window.browser || window.chrome; and maybe have a separate manifest file for firefox. I have a script in https://github.com/domoritz/himawari-8-chrome to build bundles for Firefox and Chrome from the same repo.

@electron0zero
Copy link

electron0zero commented Nov 5, 2018

I was going to open a PR but CONTRIBUTING.md says that PR will not be merged.

However, we don't have the bandwidth to support review of external contributions, and we don't want user PRs to languish, so we aren't accepting any external contributions right now.
https://github.com/googlecolab/open_in_colab/blob/master/CONTRIBUTING.md#contributing

That's why I forked and published it to Firefox Add-ons.

If you have any improvements, please send PR, I will be more then happy to merge and publish.

@domoritz
Copy link
Author

domoritz commented Nov 5, 2018

😞 @jakevdp @craigcitro Can you make an exception for this small extension? I doubt that you will get many PRs for this small extension.

@electron0zero
Copy link

electron0zero commented Nov 5, 2018

@domoritz more then happy to make a PR if it gets merged 👍

@colaboratory-team
Copy link
Collaborator

Hello - thanks for your interest in this! As noted in the above link, we're not able to accept any external contributions in this repo. We were planning to guage interest in this extension, and publish addons for other browsers if there was sufficient interest. It seems you beat us to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants