Skip to content
This repository has been archived by the owner on Aug 25, 2018. It is now read-only.

Enhancement: Inline Tests for Access #6

Open
hijonathan opened this issue Aug 7, 2014 · 4 comments
Open

Enhancement: Inline Tests for Access #6

hijonathan opened this issue Aug 7, 2014 · 4 comments

Comments

@hijonathan
Copy link

That's really the most important thing to be testing. Type checking is cool, but it doesn't really mean much if some anonymous dude is able to jam stuff into my database.

@tomlarkworthy
Copy link
Contributor

somewhat trickier to test statically, as often the rules depend on what
data is current in the Firebase. It's definitely something I wish to add
though, but probably not the kind of thing that will be done short term.

Tom

On Thu, Aug 7, 2014 at 4:37 AM, Jonathan K [email protected] wrote:

That's really the most important thing to be testing. Type checking is
cool, but it doesn't really mean much if some anonymous dude is able to jam
stuff into my database.


Reply to this email directly or view it on GitHub
#6.

@hijonathan
Copy link
Author

Could I give it mocks? That's basically what's available to us today.

@tomlarkworthy
Copy link
Contributor

What do you mean by mocks? Like specifying the contents of the Firebase and then testing whether or not something can be inserted/read (or not)? Yeah that would be interesting. I will leave this issue open and maybe we will come back to this.

@hijonathan
Copy link
Author

Yeah, that's what I had in mind.

After thinking about it more, I'm not 100% sure it really fits into the scope of this project. Just judging by the name, I wonder if it should just be doing compilation and not testing. That's your call to make, of course :]

Mocks would be sweet and are sorely needed. I bet if you asked 100 Firebase users to write a test for a non-trivial security schema, 95 of them would get some part of it wrong.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants