Transport section in module README.md files is incorrect for most modules

[meltsufin]

In most modules it says "gRPC", even though REST is enabled.

@suztomo

[suztomo]

This https://github.com/googleapis/google-cloud-java/tree/main/java-dialogflow

This comes from template: https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/java_library/README.md

## Transport

{% if metadata['repo']['transport'] == 'grpc' -%}
{{metadata['repo']['name_pretty']}} uses gRPC for the transport layer.
{% elif metadata['repo']['transport'] == 'http' -%}
{{metadata['repo']['name_pretty']}} uses HTTP/JSON for the transport layer.
{% elif metadata['repo']['transport'] == 'both' -%}
{{metadata['repo']['name_pretty']}} uses both gRPC and HTTP/JSON for the transport layer.
{% endif %}
{% endif -%}

Our procedure omits the transport option, resulting in the default value "grpc" https://github.com/googleapis/google-cloud-java/blob/main/generation/new_client/README.md.

@meltsufin In your observation, how did you check REST is enabled for an API?

[meltsufin]

The source of truth is in googleapis/googleapis BUILD.bazel https://github.com/googleapis/googleapis/blob/master/google/cloud/dialogflow/v2/BUILD.bazel#L107. New client generation should not even have to ask about it, since it's already specified.

[suztomo]

java_gapic_library(
    name = "dialogflow_java_gapic",
    srcs = [":dialogflow_proto_with_info"],
...
    transport = "grpc+rest",

Interesting. I thought that BUILD.bazel files are generated from the service yaml file. https://github.com/googleapis/googleapis/blob/master/google/cloud/dialogflow/v2/dialogflow_v2.yaml does not have any mention in grpc, rest, or transport.

[meltsufin]

cc: @blakeli0

[blakeli0]

The source of truth is in googleapis/googleapis BUILD.bazel https://github.com/googleapis/googleapis/blob/master/google/cloud/dialogflow/v2/BUILD.bazel#L107. New client generation should not even have to ask about it, since it's already specified.

Agreed. In addition, repo-metadata.json was generated with wrong transport and also never got updated, which might be the root cause.

[alicejli]

Rectifying this should be considered as part of #10090 whenever that is being worked on

[suztomo]

Let's work on this after the README files are created by the hermetic build process.