-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(all): update deps (major) #13416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs routine maintenance by updating several project dependencies to their latest major versions. This includes critical GitHub Actions used in CI/CD workflows and the cloud.google.com/go/pubsub library, ensuring the project leverages the most recent features, performance improvements, and security patches from these upstream components. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, intended to update major dependencies, introduces several dependency downgrades in the go.mod files which is concerning. Specifically, cloud.google.com/go/pubsub is downgraded in both pubsub/v2/go.mod (from v1.50.1 to v1.49.0) and pubsublite/go.mod (from v1.50.1 to v1.50.0). These downgrades are risky as they might reintroduce previously fixed bugs or vulnerabilities. I've added specific comments on the affected files highlighting these issues. It is critical to investigate the root cause of these downgrades and resolve them before merging.
| cloud.google.com/go v0.123.0 | ||
| cloud.google.com/go/iam v1.5.3 | ||
| cloud.google.com/go/pubsub v1.50.1 | ||
| cloud.google.com/go/pubsub v1.49.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cloud.google.com/go/pubsub dependency is being downgraded from v1.50.1 to v1.49.0. This is a significant regression and is highly unusual for a dependency update pull request. Downgrading can reintroduce bugs or security vulnerabilities that were fixed in later versions. Please investigate the cause of this downgrade and ensure the dependency is at v1.50.1 or a newer version.
| cloud.google.com/go/pubsub v1.50.0 | ||
| cloud.google.com/go/pubsub/v2 v2.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this PR adds cloud.google.com/go/pubsub/v2, it also downgrades the existing cloud.google.com/go/pubsub (v1) dependency from v1.50.1 to v1.50.0. Dependency downgrades are risky as they can reintroduce bugs or vulnerabilities that were fixed in later patch versions. Please investigate why this downgrade is happening. The goal should be to use the latest patch versions for all dependencies.
This PR contains the following updates:
v4->v6v7->v8v5->v6v1.50.1->v2.3.0Release Notes
actions/checkout (actions/checkout)
v6Compare Source
v5Compare Source
actions/github-script (actions/github-script)
v8: .0.0Compare Source
What's Changed
v2.327.1
Release Notes
Make sure your runner is updated to this version or newer to use this release.
New Contributors
Full Changelog: actions/github-script@v7.1.0...v8.0.0
actions/setup-go (actions/setup-go)
v6Compare Source
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.