-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(all): update opentelemetry-go-contrib monorepo #13415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(all): update opentelemetry-go-contrib monorepo #13415
Conversation
ℹ Artifact update noticeFile name: auth/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: spanner/test/opentelemetry/test/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's dependencies on the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several opentelemetry-go-contrib dependencies across various modules. The updates to go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc and go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp are the most significant. The otelgrpc update to v0.63.0 is a breaking change as it removes the StreamClientInterceptor function. It also deprecates WithSpanOptions, Extract, and Inject. The otelhttp update removes support for the OTEL_SEMCONV_STABILITY_OPT_IN environment variable. I've added comments to the relevant go.mod files highlighting these changes. Please ensure the codebase is updated to reflect these changes to avoid build failures or unexpected behavior. The other dependency updates appear to be non-breaking.
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.63.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update to go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.63.0 is a breaking change. The StreamClientInterceptor function has been removed. If this function is used in the auth module, the build will fail. The following functions are also now deprecated and should be replaced:
WithSpanOptionsExtractInject
Additionally, the update to go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.63.0 removes support for the OTEL_SEMCONV_STABILITY_OPT_IN environment variable, which may alter behavior if it was being used for configuration.
| require ( | ||
| cloud.google.com/go/spanner v1.86.1 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.61.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.63.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to v0.63.0 of go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc includes a breaking change: the StreamClientInterceptor function has been removed. This may cause these tests to fail if they rely on this function. This version also deprecates WithSpanOptions, Extract, and Inject.
This PR contains the following updates:
v1.36.0->v1.38.0v0.61.0->v0.63.0v0.61.0->v0.63.0Release Notes
open-telemetry/opentelemetry-go-contrib (go.opentelemetry.io/contrib/detectors/gcp)
v1.38.0: /v2.0.0/v0.63.0/v0.32.0/v0.18.0/v0.13.0/v0.11.0/v0.10.0Compare Source
Overview
This release is the last to support Go 1.23. The next release will require at least Go 1.24.
Added
go.opentelemetry.io/contrib/detectors/aws/ec2/v2due to deprecation ofgithub.com/aws/aws-sdk-go. (#6961)nsto deprecated runtime metricsprocess.runtime.go.gc.pause_total_nsandprocess.runtime.go.gc.pause_nsingo.opentelemetry.io/contrib/instrumentation/runtime. (#7490)go.opentelemetry.io/contrib/detectors/autodetectpackage is added to automatically compose user definedresource.Detectors at runtime. (#7522)WithLoggerProviderOptions,WithMeterProviderOptionsandWithTracerProviderOptionsoptions toNewSDKto allow passing custom options to providers ingo.opentelemetry.io/contrib/otelconf. (#7552)SeverityTextfield to logrus hook ingo.opentelemetry.io/contrib/bridges/otellogrus. (#7553)WithTraceAttributeFnoption togo.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda. (#7556)go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho. (#7668)Changed
GET /pathso it complies with the HTTP semantic conventions ingo.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux. (#7551)go.opentelemetry.io/otel/attribute.Valueandgo.opentelemetry.io/otel/log.Valuetypes to appropriatego.opentelemetry.io/otel/log.Valuetype instead oflog.StringValuein the modules below. (#7660)go.opentelemetry.io/contrib/bridges/otellogrgo.opentelemetry.io/contrib/bridges/otellogrusgo.opentelemetry.io/contrib/bridges/otelsloggo.opentelemetry.io/contrib/bridges/otelzapSeveritytype fromgo.opentelemetry.io/contrib/processors/minsevnow implements thefmt.Stringer,encoding.TextMarshaler,encoding.TextUnmarshaler,encoding.TextAppender,json.Marshaler, andjson.Unmarshalerinterfaces. (#7652)SeverityVartype fromgo.opentelemetry.io/contrib/processors/minsevnow implements thefmt.Stringer,encoding.TextMarshaler,encoding.TextUnmarshaler, andencoding.TextAppenderinterfaces. (#7652)go.opentelemetry.io/contrib/detectors/aws/lambda. (#7745)Severity.Severity()ingo.opentelemetry.io/contrib/processors/minsevnow returnslog.SeverityTrace1for severities less thanminsev.SeverityTrace1andlog.SeverityFatal4for severities greater thanminsev.SeverityFatal4instead oflog.SeverityUndefined. All other conversions are the same. (#7748)Fixed
go.opentelemetry.io/contrib/detectors/aws/ecs. (#7607)Deprecated
WithSpanOptionsingo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpcis deprecated. It is only used by the deprecated interceptor, and is unused byNewClientHandlerandNewServerHandler. (#7601)ExtractandInjectingo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpcare deprecated. These functions were initially exposed in the public API, but are now considered unnecessary. (#7689)go.opentelemetry.io/contrib/detectors/aws/ec2package is deprecated, usego.opentelemetry.io/contrib/detectors/aws/ec2/v2instead. (#7725)Removed
OTEL_SEMCONV_STABILITY_OPT_INenvironment variable as well as support for semantic conventions v1.20.0 in the modules below. (#7584)go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestfulgo.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgingo.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmuxgo.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelechogo.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptracego.opentelemetry.io/contrib/instrumentation/net/http/otelhttpStreamClientInterceptorfunction fromgo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpcis removed. (#7646)What's Changed
e0c7552by @renovate[bot] in #7515af0a60aby @renovate[bot] in #7516d90c4fdby @renovate[bot] in #75242f1f772by @renovate[bot] in #75399bd5c66by @renovate[bot] in #75403e58ba0by @renovate[bot] in #75508d1bb00by @renovate[bot] in #7559SeverityTextfield to logrus hook by @huiyifyj in #7553detectors/autodetectpackage by @MrAlias in #75225a6bbb1by @renovate[bot] in #75628d8967aby @renovate[bot] in #75677130f93by @renovate[bot] in #7586542afb5by @renovate[bot] in #7593542afb5by @renovate[bot] in #7594645b1faby @renovate[bot] in #759796f361dby @renovate[bot] in #7602a45f3dfby @renovate[bot] in #76031581f0aby @renovate[bot] in #7626f173205by @renovate[bot] in #7627interface{}withanyby @flc1125 in #762428f32e4by @renovate[bot] in #76302d32026by @renovate[bot] in #7639otelgrpc.StreamClientInterceptorby @MrAlias in #7646a7a43d2by @renovate[bot] in #76619469f96by @renovate[bot] in #7669a408d31by @renovate[bot] in #7698a408d31by @renovate[bot] in #7699autodetectby @MrAlias in #7682copyloopvarandintrangelinters by @ash2k in #767508eba0bby @renovate[bot] in #77036b04f9bby @renovate[bot] in #7708minsevseverity by @MrAlias in #765251f8813by @renovate[bot] in #77145f3141cby @renovate[bot] in #77183122310by @renovate[bot] in #77630af2bdaby @renovate[bot] in #77685981deaby @renovate[bot] in #7777d4663adby @renovate[bot] in #7782minsevSeverity.Severity()conversion by @MrAlias in #7748c5933d9by @renovate[bot] in #779645bb4baby [@renoConfiguration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.