Skip to content

fix(storage): Handle StartResumableWrite errors correctly. #13278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-storage-1.56.3
Choose a base branch
from
Open

fix(storage): Handle StartResumableWrite errors correctly. #13278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions storage/grpc_writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,19 +594,22 @@ func (s *gRPCResumableBidiWriteBufferSender) sendBuffer(ctx context.Context, buf
// error may be returned in some cases.
func (w *gRPCWriter) uploadBuffer(ctx context.Context, recvd int, start int64, doneReading bool) (obj *storagepb.Object, err error) {
if w.streamSender == nil {
if w.append {
// Appendable object semantics
w.streamSender, err = w.newGRPCAppendableObjectBufferSender()
} else if doneReading || w.forceOneShot {
// One shot semantics
w.streamSender, err = w.newGRPCOneshotBidiWriteBufferSender()
} else {
ss, sserr := func() (gRPCBidiWriteBufferSender, error) {
if w.append {
// Appendable object semantics
return w.newGRPCAppendableObjectBufferSender()
}
if doneReading || w.forceOneShot {
// One shot semantics
return w.newGRPCOneshotBidiWriteBufferSender()
}
// Resumable write semantics
w.streamSender, err = w.newGRPCResumableBidiWriteBufferSender(ctx)
}
if err != nil {
return
return w.newGRPCResumableBidiWriteBufferSender(ctx)
}()
if sserr != nil {
return nil, sserr
}
w.streamSender = ss
}

data := w.buf[:recvd]
Expand Down
Loading