Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firestore: cleanup integration test documents & collections #6855

Closed
telpirion opened this issue Oct 12, 2022 · 1 comment · Fixed by #10188
Closed

firestore: cleanup integration test documents & collections #6855

telpirion opened this issue Oct 12, 2022 · 1 comment · Fixed by #10188
Assignees
@bhshkh
Labels
api: firestore Issues related to the Firestore API. type: cleanup An internal cleanup or hygiene concern.

Comments

@telpirion
Copy link
Contributor

As stated here, the Firestore tests don't clean up after themselves.

Now that the Firestore client has Bulkwriter, we can bulk delete from the database (and thus clean up the collection).
@telpirion telpirion added the triage me I really want to be triaged. label Oct 12, 2022
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Oct 12, 2022
@telpirion telpirion added type: cleanup An internal cleanup or hygiene concern. and removed triage me I really want to be triaged. labels Oct 12, 2022
@telpirion telpirion assigned triplequark and unassigned telpirion Nov 4, 2022
@enocom enocom removed their assignment Jan 12, 2023
@bhshkh bhshkh assigned bhshkh and unassigned triplequark May 15, 2024
@bhshkh
Copy link
Contributor

bhshkh commented May 15, 2024

Most of the resources have been cleaned up in #8264
Rest are being cleaned in #10188

@bhshkh bhshkh linked a pull request May 15, 2024 that will close this issue
test(firestore): Cleanup documents created during test run #10188
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhshkh bhshkh

Labels
api: firestore Issues related to the Firestore API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(firestore): Cleanup documents created during test run bhshkh/google-cloud-go
4 participants
@enocom @telpirion @bhshkh @triplequark