Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/function arg wrapping #1127

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Feature/function arg wrapping #1127

wants to merge 11 commits into from

Commits on Nov 17, 2023

  1. Add a function that calculates the max wrapped line length for functions 

    This should be able to recurisively work its way down a stack of nested
function calls to figure out whether wrapping is actually necessary.
    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c6f822a View commit details
    Browse the repository at this point in the history

  2. Fix a bug where not all arguments were correctly parsing 

    Need to parse everything that isn't a special character instead of
creating a restricted set of things that I will parse
    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5a656f0 View commit details
    Browse the repository at this point in the history

  3. Simplify the loop logic and add a check for token existence

    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    00ae91b View commit details
    Browse the repository at this point in the history

  4. Strip out even more unnecessary logic

    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    a782ca5 View commit details
    Browse the repository at this point in the history

  5. Remove a return that might short-circuit additional logic later

    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    447eb3c View commit details
    Browse the repository at this point in the history

  6. Remove an extra space

    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3b59c64 View commit details
    Browse the repository at this point in the history

  7. Remove duplicate appends to shortList.

    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    299fa56 View commit details
    Browse the repository at this point in the history

  8. Fix variable naming to match project conventions

    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    be89f42 View commit details
    Browse the repository at this point in the history

  9. Add a knob to control whether yapf tries not to squish arguments

    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e538abb View commit details
    Browse the repository at this point in the history

  10. Allow containers to wrap gracefully 

    And do not force breaks on commas in the middle of for comprehensions
    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    54672d8 View commit details
    Browse the repository at this point in the history

  11. Add a fix for wrapping of container literals in function args.

    @jesse-sony
    jesse-sony committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    cbf8550 View commit details
    Browse the repository at this point in the history