Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turbinia-client support custom turbinia config names #1402

Open
wajihyassine opened this issue Nov 30, 2023 · 1 comment
Open

turbinia-client support custom turbinia config names #1402

wajihyassine opened this issue Nov 30, 2023 · 1 comment
Labels
Needs triage New issues that need triage process process issue

Comments

@wajihyassine
Copy link
Member

What steps will reproduce the bug?

  1. When running a turbinia-client request
  2. Setting the environment TURBINIA_API_CONFIG_PATH to a different path
  3. Command that was run: turbinia-client submit googleclouddisk --project $GCP_PROJECT --zone $GCP_ZONE --disk_name $DISK --request_id $REQUEST_ID

What is the expected behavior?

Turbinia client to parse the config without errors. I feel like we should be able to pass in a file or directory it seems to only accept directories and has to have the name turbinia_api_config.json?

What do you see instead?

TURBINIA_API_CONFIG_PATH=/home/wyassine/.turbinia_e2e_config.json
2023-11-30 19:14:22,832 ERROR turbinia - Unable to read the configuration file [Errno 20] Not a directory: '/home/wyassine/.turbinia_e2e_config.json/.turbinia_api_config.json'

Additional information

No response

@wajihyassine wajihyassine added bug process process issue Needs triage New issues that need triage labels Nov 30, 2023
@jleaniz jleaniz removed the bug label Nov 30, 2023
@jleaniz
Copy link
Collaborator

jleaniz commented Nov 30, 2023

The path here is intended as a directory, with the file name being static to make it easy to recognize where the configuration is stored. Removed the bug label for now. I see some value in supporting the use of a custom file name but seems to be simpler if you know it will be .turbinia_api_config.json

@wajihyassine wajihyassine changed the title [Bug]: turbinia-client not properly accepting TURBINIA_API_CONFIG_PATH turbinia-client support custom turbinia config names Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage New issues that need triage process process issue
Projects
None yet
Development

No branches or pull requests

2 participants