Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly crash with kernel disabling CONFIG_PROC_PID_CPUSET #214

Open
yuuzi41 opened this issue Dec 7, 2023 · 2 comments
Open

Possibly crash with kernel disabling CONFIG_PROC_PID_CPUSET #214

yuuzi41 opened this issue Dec 7, 2023 · 2 comments

Comments

@yuuzi41
Copy link

yuuzi41 commented Dec 7, 2023

It assumes that /proc/self/cpuset exists here,

int fd = signal_safe_open("/proc/self/cpuset", O_RDONLY);

but actually this file doesn't exist if kernel has been built with CONFIG_PROC_PID_CPUSET=n.

when /proc/self/cpuset doesn't exist, open() must be failed and variable fd become negative, then it will crash here.

CHECK_CONDITION(fd >= 0);

@ckennelly
Copy link
Collaborator

Does your kernel have support for membarrier with torvalds/linux@2a36ab7 (5.10 or later)?

It should be fairly rare to need to use SlowFence (the procedure where the assertion is failing), but at the point it is needed, it's important for correctness that it complete successfully.

@yuuzi41
Copy link
Author

yuuzi41 commented Dec 14, 2023

Thank you for your response.

Does your kernel have support for membarrier with torvalds/linux@2a36ab7 (5.10 or later)?

Yes, It is v5.19.2.
Actually I'm about to use https://github.com/envoyproxy/envoy on https://github.com/kata-containers/kata-containers/tree/3.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants