Permit drop frames test to run under sanitizers.

They do not produce working profiles, but this allows us to confirm our allocation/deallocation test patterns are UB-free. PiperOrigin-RevId: 705163461 Change-Id: I8e0c9dc21b85aa18673bba2edcc14ad0c85d9caf
google · Dec 11, 2024 · f939065 · f939065
1 parent 36c213b
commit f939065
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/tcmalloc/testing/BUILD b/tcmalloc/testing/BUILD
@@ -885,11 +885,6 @@ cc_test(
 create_tcmalloc_testsuite(
     name = "profile_drop_frames_test",
     srcs = ["profile_drop_frames_test.cc"],
-    tags = [
-        "noasan",
-        "nomsan",
-        "notsan",
-    ],
     deps = [
         "//tcmalloc:malloc_extension",
         "//tcmalloc/internal:profile_builder",

diff --git a/tcmalloc/testing/profile_drop_frames_test.cc b/tcmalloc/testing/profile_drop_frames_test.cc
@@ -361,11 +361,22 @@ TEST(AllocationSampleTest, ProfileDropFrames) {
     });
   };
   check(alloc_profile);
+
+#if !defined(ABSL_HAVE_ADDRESS_SANITIZER) && \
+    !defined(ABSL_HAVE_MEMORY_SANITIZER) &&  \
+    !defined(ABSL_HAVE_THREAD_SANITIZER) &&  \
+    !defined(UNDEFINED_BEHAVIOR_SANITIZER)
   EXPECT_GT(got_stacks, 20);
+#endif
   got_stacks = 0;
   check(lifetime_profile);
+#if !defined(ABSL_HAVE_ADDRESS_SANITIZER) && \
+    !defined(ABSL_HAVE_MEMORY_SANITIZER) &&  \
+    !defined(ABSL_HAVE_THREAD_SANITIZER) &&  \
+    !defined(UNDEFINED_BEHAVIOR_SANITIZER)
   EXPECT_GT(got_stacks, 20);
   EXPECT_FALSE(failed);
+#endif
 }
 
 }  // namespace