You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
arriolac opened this issue
Oct 21, 2022
· 1 comment
Assignees
Labels
semver: majorHint for users that this is an API breaking change.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
local.properties is an internal AGP file and is not meant as a mechanism for storing application secrets. The plugin should instead be modified to read for a different file (e.g. secrets.properties)
The text was updated successfully, but these errors were encountered:
Including local.properties by default also causes a problem with Flutter projects, which by default include a property for the flutter SDK path in the template local.properties (for example flutter.sdk=C\:\\Users\\me\\mycode\\MyProject\\.fvm\\flutter_sdk), which in turn causes a build error illegal escape character when building the BuildConfig.java file when using this secrets gradle plugin.
So I tried to work around this by using debug.properties and release.properties files to include just the secrets I need to in BuildConfig.java, but it still also automatically includes local.properties. It would be nice if you could tell the plugin to ignore local.properties in the plugin configuration somehow, for example something like:
secrets {
ignoreFiles.add("local.properties")
}
As a workaround I'm having to ignore keys like this, which feels wrong - every time I add another thing to local.properties I will have to remember to also exclude it from the secrets:
semver: majorHint for users that this is an API breaking change.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
local.properties
is an internal AGP file and is not meant as a mechanism for storing application secrets. The plugin should instead be modified to read for a different file (e.g.secrets.properties
)The text was updated successfully, but these errors were encountered: