Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ada implementation #504

Closed
malaise opened this issue Oct 8, 2022 · 4 comments
Closed

Ada implementation #504

malaise opened this issue Oct 8, 2022 · 4 comments

Comments

@malaise
Copy link

malaise commented Oct 8, 2022

Interested about an implementation of OLC in Ada?

I have translated the Cpp version and it is ready in my own environment (https://github.com/malaise/ada/tree/master/usr/olc).
The differences from the Cpp verrsions are:

  • Ada typing ensures that input lat and long are within the correct range (-90 - 90) and (-180 - 180)
  • Codes that are too long are rejected as invalid instead of silently truncated (which leads some coding tests to be KO)
    Except the restriction above, the tests are OK.
@bilst
Copy link
Contributor

bilst commented Oct 10, 2022

Neat! Easiest option would probably to add a link to your repo, e.g. like we have for Emacs Lisp:
https://github.com/google/open-location-code/tree/main/emacs

Happy to review a PR.

@malaise
Copy link
Author

malaise commented Oct 11, 2022

OK then.

I now have:

  • made standalone the library and test program
  • updated the test script so that it can run the "open-location-map" tests (except for lat-long out of bounds and for codes that are too long)
  • Added a short README.md
    So I think that you can add the "ada" directory with the link to the URL in my first post.

Thank you

@malaise
Copy link
Author

malaise commented Oct 28, 2022

I wrote:

So I think that you can add the "ada" directory with the link to the URL in my first post.

Or do you want me to do it and submit a PR?

@drinckes
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants