Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Safari: ARQL truncates canonicalWebPageURL when it contains encoded query parameters #4570

Open
3 of 13 tasks
milesgreen opened this issue Nov 16, 2023 · 2 comments
Open
3 of 13 tasks
Labels
flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue

Comments

@milesgreen
Copy link
Contributor

milesgreen commented Nov 16, 2023

Description

When passing canonicalWebPageURL to ARQL as part of the USDZ file path, if the canonicalWebPageURL contains multiple query parameters as part of the URL, even when URI encoded, ARQL will truncate the shared URL down to just the first parameter, when clicking on the Share button from within the ARQL session.

For example, when giving a USDZ a path of:

https://example.com/example.usdz#canonicalWebPageURL=https%3A%2F%2Fexample.com%2F%3Ffoo%3D111%26bar%3D222

The shared URL will get truncated down to:

https://example.com/?foo=111

Rather than:

https://example.com/?foo=111&bar=222

This makes it not possible to specify a canonicalWebPageURL containing multiple query string parameters.

This does work in iOS Chrome and canonicalWebPageURL can contain multiple encoded query parameters. So it appears to be an issue somewhere with Safari hand off to QuickLook, rather than QuickLook itself?

Live Demo

Issue reported here:
https://bugs.webkit.org/show_bug.cgi?id=248219

Version

  • model-viewer: any

Browser Affected

  • Chrome, version: xx.x.xxxx.xx
  • Edge
  • Firefox
  • IE
  • Safari

OS

  • Android
  • iOS, v16 and v17
  • Linux
  • MacOS
  • Windows

AR

  • WebXR
  • SceneViewer
  • QuickLook
@elalish elalish added the flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue label Nov 20, 2023
@elalish
Copy link
Collaborator

elalish commented Nov 20, 2023

Thanks for filing the Webkit bug!

@milesgreen
Copy link
Contributor Author

@AdaRoseCannon - one more iOS ARQL issue...


Issue also reported on WebKit Bugzilla:
https://bugs.webkit.org/show_bug.cgi?id=248219

Reported via Feedback Assistant (FB13779483)


canonicalWebPageURL share links with multiple query parameters get truncated when shared.

Fails in iOS Safari. Works in iOS Chrome.

Repro:

  • Visit: https://arquicklook-usdz-params.glitch.me
  • Set the ‘Share Link’ dropdown option to ‘Complex Share Link’
  • This will update the USDZ link above.
  • Observe in the Code Preview showing canonicalWebPageURL set with an encoded URL with 4 query parameters.
  • Tap the USDZ link to launch ARQL.
  • Model opens in ARQL.
  • Tap the Share button at top right.
  • Copy the shared URL and paste back into Safari.
  • Observe the shared URL is truncated. It should be:

https://arquicklook-usdz-params.glitch.me/share.html?foo=1111&bar=2222&spam=3333&eggs=4444

But is only shared as:

https://arquicklook-usdz-params.glitch.me/share.html?foo=1111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue
Projects
None yet
Development

No branches or pull requests

2 participants