-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Set no-floating-promises
to error
#793
Comments
hey @danielbankhead can we move forward with this now? I can make a PR if so, thank you! |
@naseemkullah feel free to create a PR, however it will take some time before we do another major release |
Working on another major release with some changes to drop Node 14/16 soon. Anyone want to create a PR I can help merge. |
@tonycoco We cannot drop Node 14/16 without a proposal to update all googleapis Node.js client libraries. We're planning to get to this sometime this semester. |
Un-revert #808 and set
no-floating-promises
toerror
Context:
Dependency:
system-test/fixtures
to.eslintignore
googleapis/synthtool#1877The text was updated successfully, but these errors were encountered: