Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HidingField should indicate the name of the field #4775

Open
delanym opened this issue Jan 17, 2025 · 2 comments
Open

HidingField should indicate the name of the field #4775

delanym opened this issue Jan 17, 2025 · 2 comments

Comments

@delanym
Copy link
Contributor

delanym commented Jan 17, 2025

In Error-prone v2.33.0

Hiding fields of superclasses may cause confusion and errors. This field is hiding a field of the same name in superclass: DataRecord

Ok, but what field is that?
@graememorgan
Copy link
Member

The finding should be attached to the line of the field declaration: is it not?

(I agree it'd be nice to include the field name, too, though.)

@delanym
Copy link
Contributor Author

delanym commented Jan 20, 2025

The output doesn't include the name. I have to go to the line number.

copybara-service bot pushed a commit that referenced this issue Jan 22, 2025
@graememorgan
Tweak the diagnostic in HidingField to include the field name.
ca80417 
Fixes external #4775.

PiperOrigin-RevId: 717480797
@copybara-service copybara-service bot mentioned this issue Jan 22, 2025
Merged
copybara-service bot pushed a commit that referenced this issue Jan 22, 2025
@graememorgan
Tweak the diagnostic in HidingField to include the field name.
f8d55d0 
Fixes external #4775.

PiperOrigin-RevId: 718350551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delanym @graememorgan