You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
a49af36 introduced a compulsory url prefix, without any checking, into the credentials helper for referencing server entries.
On systems with docker-credentials-secretservice, required on ubuntu 18.04 through docker-compose and provided by golang-docker-credential-helpers, docker login <registry> strips any registry url down to store credentials with only the hostname as a key.
This means that with the compulsory https:// prefix, values cannot be retrieved through containerregistry for any system where the credsStore is secretservice, and through its own mechanism of searching out credential stores, this adoption of secretstore as a container cannot be avoided if it is on the $PATH when docker login is invoked (or even if the secretstorecredsStore were to be preferred). rules_docker is obviously afflicted through both its direct dependency on containerregistry, and the puller par binary.
Can the compulsory url prefix be dropped and pathways to stores that require the url (gcr as observed) be required to provide the format needed by the selected credsStore, making this an implementation detail?
The text was updated successfully, but these errors were encountered:
werkt
changed the title
forced url server specification fails to match for docker-credentials-secretstore
forced url server specification fails to match for docker-credentials-secretservice
Mar 13, 2019
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
a49af36 introduced a compulsory url prefix, without any checking, into the credentials helper for referencing server entries.
On systems with
docker-credentials-secretservice
, required on ubuntu 18.04 throughdocker-compose
and provided bygolang-docker-credential-helpers
,docker login <registry>
strips any registry url down to store credentials with only the hostname as a key.This means that with the compulsory
https://
prefix, values cannot be retrieved through containerregistry for any system where thecredsStore
issecretservice
, and through its own mechanism of searching out credential stores, this adoption ofsecretstore
as a container cannot be avoided if it is on the$PATH
whendocker login
is invoked (or even if thesecretstore
credsStore
were to be preferred).rules_docker
is obviously afflicted through both its direct dependency oncontainerregistry
, and thepuller
par binary.Can the compulsory url prefix be dropped and pathways to stores that require the url (gcr as observed) be required to provide the format needed by the selected
credsStore
, making this an implementation detail?The text was updated successfully, but these errors were encountered: