Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page down/up scroll length #153

Open
aaxu opened this issue Feb 13, 2018 · 3 comments
Open

Page down/up scroll length #153

aaxu opened this issue Feb 13, 2018 · 3 comments

Comments

@aaxu
Copy link
Contributor

aaxu commented Feb 13, 2018

I was thinking that it is really weird if we actually scroll down/up by one entire page. I never thought about it but it comforts me and I know where I am in the document when I am able to see some parts of the previous page. Perhaps we could make page down/up scroll by 0.8 * numRows or 0.9? Though, this may just be me and I'm not sure if anyone else experiences this. Any thoughts?

@dschuyler
Copy link
Collaborator

I'd like to keep the default at a full page (1.0), but I'm okay with having a pref option to scroll by a different amount (0.8).

Though would you prefer to do N lines rather than a percentage? i.e. overlap by 1 line (or 2). I'd like to keep the default at 0 if we overlap lines. Maybe a pref like "line_overlap_on_page_scroll": 0,.

@aaxu
Copy link
Contributor Author

aaxu commented Mar 15, 2018

Oh yeah that sounds good. The only time I found this to be an issue was when I was writing code and neared the bottom of the screen. I wanted to be able to see below my current line and above my current line to keep my sense of position in the file document. I had to scroll down (which also brings another issue to mind, maybe we should be able to scroll up to 1 screen past the end of the last line of the document?), fix my cursor position, and then resume typing. I think something like setting the current cursor position to be at the optimalCursorPosition is something closer to what I'm looking for, rather than an adjustment to page down.

@dschuyler
Copy link
Collaborator

I don't know if this will help, but fyi, sometimes when I want to adjust the scroll position to move just few lines I'll use ctrl+up/ctrl+down. Those scroll by one line without moving the cursor position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants