Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asm to version 9.2 #141

Open
gregallen opened this issue Oct 21, 2021 · 7 comments
Open

Update asm to version 9.2 #141

gregallen opened this issue Oct 21, 2021 · 7 comments
Labels

Comments

@gregallen
Copy link

Need to support java 17

@ronshapiro
Copy link
Contributor

ronshapiro commented Oct 21, 2021

Looks like we're on 9.3 internally - shall we jump straight there?

@gregallen
Copy link
Author

yes - that would be great - want this downstream in google allocation instrumenter - see google/allocation-instrumenter#43

@amalloy amalloy added the P2 label Oct 29, 2021
@amalloy
Copy link

amalloy commented Oct 29, 2021

Hey, @ronshapiro. I'm on issue triage this week, and I'm a little confused by your remark about 9.3. AFAICT there's no such thing as 9.3 in maven central (https://mvnrepository.com/artifact/org.ow2.asm/asm), so I'm not sure how we could update to it. Could you explain this further for someone new to updating bazel-common dependencies?

@ronshapiro
Copy link
Contributor

ronshapiro commented Oct 31, 2021 via email

@gregallen
Copy link
Author

@amalloy any chance this update could be done? I see there is a new update script to help

@gregallen
Copy link
Author

@ronshapiro @amalloy any chance you could help to progress this? thanks!

@ronshapiro
Copy link
Contributor

Sorry I kept losing track of this. Just opened a commit internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants