Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document AutoFactory#className and eagerly enforce the contract #79

Open
Zubnix opened this issue Feb 22, 2014 · 2 comments
Open

Document AutoFactory#className and eagerly enforce the contract #79

Zubnix opened this issue Feb 22, 2014 · 2 comments
Assignees
Labels
Component: factory P4 type=api-docs Change/add API documentation

Comments

@Zubnix
Copy link

Zubnix commented Feb 22, 2014

className property of the AutoFactory should either accept the fully qualified name (preferably, as it name implies) or the javadoc should clearly mention that it is actually the simple classname (current situation which actually limits functionality so not really desired(?)).

@gk5885
Copy link
Contributor

gk5885 commented Feb 25, 2014

The behavior is WAI. There was a lot of discussion about that and because changing the package has a lot of implications on which visibility modifiers are acceptable, we decided that it was a lot of added complexity for little benefit.

I completely agree about the javadocs though.

@gk5885 gk5885 self-assigned this Feb 25, 2014
@gk5885
Copy link
Contributor

gk5885 commented Feb 25, 2014

And come to think of it, we should definitely have a good set of checks to ensure that it is a valid identifier with good, useful error messages.

@raghsriniv raghsriniv added the P3 label Jun 24, 2019
@kluever kluever added type=api-docs Change/add API documentation P4 and removed P3 labels Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: factory P4 type=api-docs Change/add API documentation
Projects
None yet
Development

No branches or pull requests

5 participants