Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support guices @BindingAnnotation? or flag as an error? #214

Open
lukesandberg opened this issue Mar 31, 2015 · 2 comments
Open

Support guices @BindingAnnotation? or flag as an error? #214

lukesandberg opened this issue Mar 31, 2015 · 2 comments
Labels
Component: factory P3 type=addition A new feature
Milestone
Auto-Factory 1.0-...

Comments

@lukesandberg
Copy link
Contributor

Part of using @autofactory in a guice project is migrating all the binding annotations use the @qualifier annotation instead of (or in addition to) @BindingAnnotation. It would be nice if @autofactory flagged this as an error (or if it just worked).

The current state is that it ignores @BindingAnnotation meaning that it may generate a factory that uses different bindings than the user intended.
@lukesandberg
Copy link
Contributor Author

Oh also if/when #213 is fixed it would be nice to get similar support or errors for com.google.inject.Provider

@cgruber cgruber added this to the AutoValue 1.1 milestone Apr 20, 2015
@cgruber
Copy link
Contributor

cgruber commented Apr 21, 2015

Yeah - this is a good idea.

@raghsriniv raghsriniv added the P3 label Jun 24, 2019
@kluever kluever added the type=addition A new feature label Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: factory P3 type=addition A new feature
Projects
None yet
Milestone
Auto-Factory 1.0-beta2
Development

No branches or pull requests
4 participants
@lukesandberg @cgruber @kluever @raghsriniv