Add varying Vloop boundary condition test. Increases coverage.

PiperOrigin-RevId: 739222295

Author: jcitrin

torax/core_profiles/updaters.py

@@ -416,7 +416,7 @@ def compute_boundary_conditions_for_t_plus_dt(
                   dt=dt,
                   vloop_lcfs_t=dynamic_runtime_params_slice_t.profile_conditions.vloop_lcfs,
                   vloop_lcfs_t_plus_dt=profile_conditions_t_plus_dt.vloop_lcfs,
-                  psi_lcfs_t=core_profiles_t.psi.face_value()[-1],
+                  psi_lcfs_t=core_profiles_t.psi.right_face_constraint,
                   theta=static_runtime_params_slice.stepper.theta_imp,
               )
               if profile_conditions_t_plus_dt.use_vloop_lcfs_boundary_condition

torax/tests/sim_test.py

@@ -438,10 +438,10 @@ class SimTest(sim_test_case.SimTestCase):
           0,
       ),
       # Tests current diffusion with vloop BC.
-      # Initial Ip from parameters and psi from CHEASE.
+      # Initial Ip from parameters and psi from CHEASE, varying vloop BC.
       (
-          'test_psichease_ip_parameters_vloop',
-          'test_psichease_ip_parameters_vloop.py',
+          'test_psichease_ip_parameters_vloop_varying',
+          'test_psichease_ip_parameters_vloop_varying.py',
           _ALL_PROFILES,
           0,
       ),

…ta/test_psichease_ip_parameters_vloop.nc …psichease_ip_parameters_vloop_varying.nctorax/tests/test_data/test_psichease_ip_parameters_vloop.nc renamed to torax/tests/test_data/test_psichease_ip_parameters_vloop_varying.nc torax/tests/test_data/test_psichease_ip_parameters_vloop.nc renamed to torax/tests/test_data/test_psichease_ip_parameters_vloop_varying.nc

@@ -12,14 +12,19 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Identical to test_psichease_ip_chease but V-loop boundary condition."""
+"""Identical to test_psichease_ip_chease_vloop but with varying vloop_lcfs."""
 
 import copy
+import numpy as np
 from torax.tests.test_data import test_psichease_ip_parameters
 
 
 CONFIG = copy.deepcopy(test_psichease_ip_parameters.CONFIG)
+times = np.linspace(0, 3, 100)
+# 1 Hz frequency
+vloop = 8.7 + 10 * np.sin(2 * np.pi * times)
+
 CONFIG['runtime_params']['profile_conditions'][
     'use_vloop_lcfs_boundary_condition'
 ] = True
-CONFIG['runtime_params']['profile_conditions']['vloop_lcfs'] = 8.7
+CONFIG['runtime_params']['profile_conditions']['vloop_lcfs'] = (times, vloop)