Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove separators from panda_nohand.xml default classes #60

Conversation

peterdavidfagan
Copy link

@peterdavidfagan peterdavidfagan commented May 23, 2024

I encountered an error when migrating to the robot_descriptions package related to reading official mjcf files that contain separators in class names. Further details of this issue can be found here.

This pull request updates the panda_nohand.xml model by renaming default class names to ensure the model can be read using the dm_control.mjcf API.

@peterdavidfagan peterdavidfagan changed the title Remove Separators from panda_nohand.xml Remove separators from panda_nohand.xml default classes May 23, 2024
@yuvaltassa yuvaltassa requested a review from erez-tom May 23, 2024 16:44
@kevinzakka
Copy link
Collaborator

Hi @peterdavidfagan, my usual way of loading this model is as follows:

panda_mjcf = mjcf.from_path(PANDA_NO_HAND_XML.as_posix(), escape_separators=True)

Agreed though that it's better to be consistent across all models so going to approve this PR.

@peterdavidfagan
Copy link
Author

Thanks @kevinzakka the above is working for me, not sure how I missed the escape_parameters argument. Thanks for this clarification.

@kevinzakka
Copy link
Collaborator

Hi @peterdavidfagan, I think this broke a few dependencies in MuJoCo MPC so going to close for now.

@kevinzakka kevinzakka closed this Aug 23, 2024
@peterdavidfagan
Copy link
Author

Thanks for letting me know @kevinzakka and ok sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants