Skip to content

Commit 97bfc9b

Browse files
committed
Update golden images for ARM64
AMD64 and ARM64 seems to have small difference in float64 calculations. Reference: golang/go#36536 Signed-off-by: Eng Zer Jun <[email protected]>
1 parent 463db7c commit 97bfc9b

File tree

7 files changed

+6
-4
lines changed

7 files changed

+6
-4
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
name: CI
22

33
on:
4-
pull_request:
5-
branches: [ master ]
4+
push:
65

76
jobs:
87

98
build:
109
name: Build
1110
strategy:
11+
fail-fast: false
1212
matrix:
1313
go-version: [1.24.x, 1.23.x]
1414
platform: [ubuntu-latest, macos-latest]

plotter/filledLine_example_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"image/color"
99
"log"
1010
"math/rand/v2"
11+
"runtime"
1112

1213
"gonum.org/v1/plot"
1314
"gonum.org/v1/plot/plotter"
@@ -45,7 +46,7 @@ func ExampleLine_filledLine() {
4546

4647
p.Add(filled)
4748

48-
err = p.Save(200, 200, "testdata/filledLine.png")
49+
err = p.Save(200, 200, "testdata/filledLine_"+runtime.GOARCH+".png")
4950
if err != nil {
5051
log.Panic(err)
5152
}

plotter/filledLine_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"image/color"
99
"log"
1010
"math/rand/v2"
11+
"runtime"
1112
"testing"
1213

1314
"gonum.org/v1/plot"
@@ -58,6 +59,6 @@ func clippedFilledLine() {
5859
}
5960

6061
func TestFilledLine(t *testing.T) {
61-
cmpimg.CheckPlot(ExampleLine_filledLine, t, "filledLine.png")
62+
cmpimg.CheckPlot(ExampleLine_filledLine, t, "filledLine_"+runtime.GOARCH+".png")
6263
cmpimg.CheckPlot(clippedFilledLine, t, "clippedFilledLine.png")
6364
}
1 Byte
Loading
1.22 KB
Loading
12.6 KB
Loading

0 commit comments

Comments
 (0)