New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Moving file while using --new-from-rev
#4349
Labels
Comments
amenasria
changed the title
Moving file while using
[Doc] Moving file while using Feb 6, 2024
--new-from-rev
--new-from-rev
ldez
added
enhancement
New feature or improvement
area: docs
and removed
bug
Something isn't working
labels
Feb 7, 2024
5 tasks
ldez
added
question
Further information is requested
area: docs
and removed
enhancement
New feature or improvement
area: docs
question
Further information is requested
labels
Apr 24, 2024
Hello, I feel expected: I don't know how to improve the documentation about that 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Welcome
Description of the problem
We recently used the
new-from-rev
key in our configuration to enablerevive
on our large codebase to avoid having to fix all the errors directly. It was really practical at first !One major caveat of
new-from-rev
imo is moving files. Let's say I have a legacy filehello.go
with 100 lints (i.e linter errors). Thenew-from-rev
parameter will silence them all. But if I rename this file tohello_world.go
or move it to another folder then all the lints will rise again.I think this should be mentioned in https://golangci-lint.run/usage/faq/#how-to-integrate-golangci-lint-into-large-project-with-thousands-of-issues to make people aware of the cost of relying on
new-from-rev
.Version of golangci-lint
Configuration
https://github.com/DataDog/datadog-agent/blob/fcb19ce078e7969d285565beec5d374c5fd623e1/.golangci.yml
Go environment
Validation
The text was updated successfully, but these errors were encountered: