tests: hide warn during tests

Author: ldez

.golangci.yml

@@ -175,7 +175,7 @@ issues:
 
 run:
   timeout: 5m
-  skip-dirs:
+  skip-dirs: # TODO(ldez): should be replaced by `issues.exclude-dirs` after the next release.
     - test/testdata_etc # test files
     - internal/cache # extracted from Go code
     - internal/renameio # extracted from Go code

pkg/commands/run.go

@@ -460,7 +460,7 @@ func (c *runCommand) setupExitCode(ctx context.Context) {
 		return
 	}
 
-	needFailOnWarnings := os.Getenv(lintersdb.EnvTestRun) == "1" || os.Getenv(envFailOnWarnings) == "1"
+	needFailOnWarnings := os.Getenv(logutils.EnvTestRun) == "1" || os.Getenv(envFailOnWarnings) == "1"
 	if needFailOnWarnings && len(c.reportData.Warnings) != 0 {
 		c.exitCode = exitcodes.WarningInTest
 		return

pkg/config/loader.go

@@ -118,24 +118,24 @@ func (l *Loader) handleGoVersion() {
 
 func (l *Loader) handleDeprecation() {
 	if len(l.cfg.Run.SkipFiles) > 0 {
-		l.log.Warnf("The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`.")
+		l.warn("The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`.")
 		l.cfg.Issues.ExcludeFiles = l.cfg.Run.SkipFiles
 	}
 
 	if len(l.cfg.Run.SkipDirs) > 0 {
-		l.log.Warnf("The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`.")
+		l.warn("The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`.")
 		l.cfg.Issues.ExcludeDirs = l.cfg.Run.SkipDirs
 	}
 
 	// The 2 options are true by default.
 	if !l.cfg.Run.UseDefaultSkipDirs {
-		l.log.Warnf("The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`.")
+		l.warn("The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`.")
 	}
 	l.cfg.Issues.UseDefaultExcludeDirs = l.cfg.Run.UseDefaultSkipDirs && l.cfg.Issues.UseDefaultExcludeDirs
 
 	// The 2 options are false by default.
 	if l.cfg.Run.ShowStats {
-		l.log.Warnf("The configuration option `run.show-stats` is deprecated, please use `output.show-stats`")
+		l.warn("The configuration option `run.show-stats` is deprecated, please use `output.show-stats`")
 	}
 	l.cfg.Output.ShowStats = l.cfg.Run.ShowStats || l.cfg.Output.ShowStats
 }
@@ -319,6 +319,14 @@ func (l *Loader) appendStringSlice(name string, current *[]string) {
 	}
 }
 
+func (l *Loader) warn(format string) {
+	if l.cfg.InternalTest || l.cfg.InternalCmdTest || os.Getenv(logutils.EnvTestRun) == "1" {
+		return
+	}
+
+	l.log.Warnf(format)
+}
+
 func fileDecoderHook() viper.DecoderConfigOption {
 	return viper.DecodeHook(mapstructure.ComposeDecodeHookFunc(
 		// Default hooks (https://github.com/spf13/viper/blob/518241257478c557633ab36e474dfcaeb9a3c623/viper.go#L135-L138).

pkg/lint/lintersdb/manager.go

@@ -14,9 +14,6 @@ import (
 	"github.com/golangci/golangci-lint/pkg/logutils"
 )
 
-// EnvTestRun value: "1"
-const EnvTestRun = "GL_TEST_RUN"
-
 type Builder interface {
 	Build(cfg *config.Config) ([]*linter.Config, error)
 }
@@ -97,7 +94,7 @@ func (m *Manager) GetAllLinterConfigsForPreset(p string) []*linter.Config {
 func (m *Manager) GetEnabledLintersMap() (map[string]*linter.Config, error) {
 	enabledLinters := m.build(m.GetAllEnabledByDefaultLinters())
 
-	if os.Getenv(EnvTestRun) == "1" {
+	if os.Getenv(logutils.EnvTestRun) == "1" {
 		m.verbosePrintLintersStatus(enabledLinters)
 	}
 

pkg/logutils/logutils.go

@@ -5,6 +5,9 @@ import (
 	"strings"
 )
 
+// EnvTestRun value: "1"
+const EnvTestRun = "GL_TEST_RUN"
+
 // envDebug value: one or several debug keys.
 // examples:
 // - Remove output to `/dev/null`: `GL_DEBUG=linters_output ./golangci-lint run`

test/enabled_linters_test.go

@@ -10,12 +10,13 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"github.com/golangci/golangci-lint/pkg/lint/lintersdb"
+	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/test/testshared"
 )
 
 func TestEnabledLinters(t *testing.T) {
 	// require to display the message "Active x linters: [x,y]"
-	t.Setenv(lintersdb.EnvTestRun, "1")
+	t.Setenv(logutils.EnvTestRun, "1")
 
 	cases := []struct {
 		name           string

test/run_test.go

@@ -370,7 +370,7 @@ func TestSkippedDirsNoMatchArg(t *testing.T) {
 		WithNoConfig().
 		WithArgs(
 			"--print-issued-lines=false",
-			"--skip-dirs", dir,
+			"--exclude-dirs", dir,
 			"-Erevive",
 		).
 		WithTargetPath(dir).