Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update map.sh #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update map.sh #222

wants to merge 1 commit into from

Conversation

rmdhfz
Copy link

@rmdhfz rmdhfz commented Apr 28, 2023

This pull request optimizes and fixes the bash script by making the following changes:

  • Replaced #!/bin/sh with #!/bin/bash to ensure that the script uses bash instead of sh.
  • Renamed the findURL function to find_url to conform to the standard naming convention in bash.
  • Used double quotes instead of single quotes in the find_url function to allow variable expansion.
  • Used sed instead of cut to extract the lesson name from the article filename in the find_url function.
  • Used cd instead of pushd and popd to change directories.
  • Used while read -r instead of echo "$mapping" | while read to avoid a subshell and potential issues with whitespace in the input.
  • Replaced sed "s/[0-9]* //" with cut -d' ' -f2- to extract the title from the mapping input.

This pull request optimizes and fixes the bash script by making the following changes:

- Replaced #!/bin/sh with #!/bin/bash to ensure that the script uses bash instead of sh.
- Renamed the findURL function to find_url to conform to the standard naming convention in bash.
- Used double quotes instead of single quotes in the find_url function to allow variable expansion.
- Used sed instead of cut to extract the lesson name from the article filename in the find_url function.
- Used cd instead of pushd and popd to change directories.
- Used while read -r instead of echo "$mapping" | while read to avoid a subshell and potential issues with whitespace in the input.
- Replaced sed "s/[0-9]* //" with cut -d' ' -f2- to extract the title from the mapping input.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/490075.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants