{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":27146054,"defaultBranch":"master","name":"tools","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-11-25T21:07:26.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726846682.0","currentOid":""},"activityList":{"items":[{"before":"c59bc300b24fa84ed20ac1ebc68ec449113cf902","after":"e55961d46ceb7aac2513cb859c23942ec2ce11db","ref":"refs/heads/master","pushedAt":"2024-09-26T21:58:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/gcimporter: use types.NewInterfaceType\n\nUse types.NewInterfaceType directly. This has been available since Go 1.11.\n\nChange-Id: I3669ce485bc99a758530158db02a470d81ad7b85\nReviewed-on: https://go-review.googlesource.com/c/tools/+/615697\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan \nCommit-Queue: Tim King ","shortMessageHtmlLink":"internal/gcimporter: use types.NewInterfaceType"}},{"before":"4fc0d79003330deeb6cbbb1b30f2981bd9183ade","after":"c59bc300b24fa84ed20ac1ebc68ec449113cf902","ref":"refs/heads/master","pushedAt":"2024-09-26T21:56:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/gcimporter: vary the value of any in predeclared\n\nVary the types in predeclared() based on the runtime value of any\nin types.Universe (either universeAnyNoAlias or universeAnyAlias).\n\nChange-Id: Iacf43d21c7d078706ac20ded7ffdeadffbb4baf5\nReviewed-on: https://go-review.googlesource.com/c/tools/+/615683\nCommit-Queue: Tim King \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/gcimporter: vary the value of any in predeclared"}},{"before":"f05b5f456f7bba276d03c3f76ace90c60d9e0901","after":"4fc0d79003330deeb6cbbb1b30f2981bd9183ade","ref":"refs/heads/master","pushedAt":"2024-09-26T20:52:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/gcimporter: remove goexperiment.unified tags\n\ngoexperiment.unified was removed in 1.21.\n\nChange-Id: I388d657da578f33616c45b8a18a2266443956757\nReviewed-on: https://go-review.googlesource.com/c/tools/+/615995\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nAuto-Submit: Tim King ","shortMessageHtmlLink":"internal/gcimporter: remove goexperiment.unified tags"}},{"before":"3483a5ef405857d5d1453849fcaa2964469a9aa5","after":"f05b5f456f7bba276d03c3f76ace90c60d9e0901","ref":"refs/heads/master","pushedAt":"2024-09-26T18:34:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/packages: document the role of PWD\n\nFixes golang/go#67757\n\nChange-Id: I783fa88cfcfb77fdadc02a303cbaec4910f8b8fc\nReviewed-on: https://go-review.googlesource.com/c/tools/+/616057\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Matloob \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"go/packages: document the role of PWD"}},{"before":"75350b9b9987b80d40b3007d77780b0e127e7038","after":"3483a5ef405857d5d1453849fcaa2964469a9aa5","ref":"refs/heads/master","pushedAt":"2024-09-26T18:32:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/packages: use link notation in comments for godoc rendering\n\nfixes golang/go#69618\n\nChange-Id: I7585b7cf92472b4ff1944ad3486cd930475143d1\nReviewed-on: https://go-review.googlesource.com/c/tools/+/615695\nReviewed-by: Michael Matloob \nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"go/packages: use link notation in comments for godoc rendering"}},{"before":"1c9ca8b8bac40ec8a6e010a7c5b60f47591e7db8","after":"75350b9b9987b80d40b3007d77780b0e127e7038","ref":"refs/heads/master","pushedAt":"2024-09-26T18:31:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: remove import of loader from builder_test.go\n\nUnused import of loader in builder_test.go.\n\nChange-Id: I518f7f1d866064bbb89d4690e9c5c182f80d1a47\nReviewed-on: https://go-review.googlesource.com/c/tools/+/616175\nAuto-Submit: Tim King \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"go/ssa: remove import of loader from builder_test.go"}},{"before":"23e1af6910ab6f93deef899f7b65e103a6ee446e","after":"1c9ca8b8bac40ec8a6e010a7c5b60f47591e7db8","ref":"refs/heads/master","pushedAt":"2024-09-26T17:11:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/types/objectpath,internal/aliases: miscellaneous clean up of tests that set gotypesalias\n\n* Fix default value test (\"\") for TestNewAlias.\n* Updates references to 1.19 to 1.22.\n\nChange-Id: I9c19621e820c90c265235afff863863d03f2d171\nReviewed-on: https://go-review.googlesource.com/c/tools/+/615696\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"go/types/objectpath,internal/aliases: miscellaneous clean up of tests…"}},{"before":"8adb6e83db735d889de177549fd9c9526c71b07f","after":"23e1af6910ab6f93deef899f7b65e103a6ee446e","ref":"refs/heads/master","pushedAt":"2024-09-26T17:08:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: migrate TestGenericFunctionSelector away from loader\n\nUse qualified identifier to check instantiated function.\n\nUpdates golang/go#69556\n\nChange-Id: I857de1b3d13d052dc09d96454715f8128237362e\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614995\nAuto-Submit: Alan Donovan \nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Tim King ","shortMessageHtmlLink":"go/ssa: migrate TestGenericFunctionSelector away from loader"}},{"before":"7bb384dcf895120f692ab71f688d1ff31d193e78","after":"8adb6e83db735d889de177549fd9c9526c71b07f","ref":"refs/heads/master","pushedAt":"2024-09-26T16:52:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: migrate TestTypeparamTest away from loader\n\nUpdates golang/go#69556\n\nChange-Id: I5683a0139595c5b505e25cdccba3dad422cc6d69\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614975\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Tim King \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"go/ssa: migrate TestTypeparamTest away from loader"}},{"before":"faf6e2869e8e491d9feb58d0f18db6f2a209b808","after":"7bb384dcf895120f692ab71f688d1ff31d193e78","ref":"refs/heads/master","pushedAt":"2024-09-26T14:44:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/test/integration/bench: add an IWL test that opens files\n\nThe existing BenchmarkInitialWorkspaceLoad does not open files, which\nmeans it measures only the speed of loading and verifying the workspace\nstate, with hot caches. It does not measure the memory or time consumed\nwhen starting to actually work on a file.\n\nFix this by opening a file.\n\nAlso, add -profile.block to gopls and -gopls_blockprofile to gopls\nbenchmarks, for better diagnosis of contention.\n\nChange-Id: I63ef7c9a26ca71ddd9b6895369921655eaa4f090\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614163\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"gopls/internal/test/integration/bench: add an IWL test that opens files"}},{"before":"81a4242b11cb7a2a89ea4fbf7536132e462c67ad","after":"faf6e2869e8e491d9feb58d0f18db6f2a209b808","ref":"refs/heads/master","pushedAt":"2024-09-26T14:23:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: migrate TestGenericAliases away from loader\n\nUpdates golang/go#69556\n\nChange-Id: I50ac457a379afa9ceccd0031397fca7b38e7f689\nReviewed-on: https://go-review.googlesource.com/c/tools/+/615015\nReviewed-by: Tim King \nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/ssa: migrate TestGenericAliases away from loader"}},{"before":"54110aa1994bf24eedb96ac20ac0c99fd270c0b6","after":"81a4242b11cb7a2a89ea4fbf7536132e462c67ad","ref":"refs/heads/master","pushedAt":"2024-09-25T18:37:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/gcimporter: update TestIssueAliases expectation\n\nFixes golang/go#69627\n\nChange-Id: I96460aa3c4b2863ae50fefd09a85e670d166b773\nReviewed-on: https://go-review.googlesource.com/c/tools/+/615855\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"internal/gcimporter: update TestIssueAliases expectation"}},{"before":"b577f77ea7365241868456d7a0cc210e6045087d","after":"54110aa1994bf24eedb96ac20ac0c99fd270c0b6","ref":"refs/heads/master","pushedAt":"2024-09-25T18:30:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/modindex: package for indexing GOMODCACHE\n\nThis CL contains the first part of a package for maintaining an\non-disk index of the module cache. The index is stored as text.\nEventually it will consist of a header, followed by groups of lines,\none for each import path, and sorted by package name. The groups of lines\nstart with a header containing the package name, import path, name of the\ndirectory, and semantic version,\nfollowed (but not in this first CL) by lines, each of which contains\ninformation about one exported symbol.\n\nThis CL only contains the code for computing and updating the information\nabout directories and import paths, and reading the index. It does not\ncompute anything about exported symbols, which will be in the next CL,\nand hence it does not present an API for looking up information about\ncompletion of selectors.\n\nThere is a test that among directories with the same import path it can\nfind the one with the largest semantic version.\n\nChange-Id: I0883ea732cf34f6700f5495e6dfd594e8f286af9\nReviewed-on: https://go-review.googlesource.com/c/tools/+/612355\nTryBot-Bypass: Peter Weinberger \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"internal/modindex: package for indexing GOMODCACHE"}},{"before":"83326b7c9c92f8b3e29c04902f606738084848ba","after":"b577f77ea7365241868456d7a0cc210e6045087d","ref":"refs/heads/master","pushedAt":"2024-09-25T18:18:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/cache: remove unnecessary active package check\n\nSnapshot.TypeCheck implemented an eager check for active packages that\nwas redundant with the same check in Snapshot.forEachPackage. Remove it.\n\nChange-Id: Ia58c85ac4e8795ddcc47c124d006c609b8ae715e\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614155\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/cache: remove unnecessary active package check"}},{"before":"34638fc6a41e9e7ec6ee99535ecb24a570b8f222","after":"83326b7c9c92f8b3e29c04902f606738084848ba","ref":"refs/heads/master","pushedAt":"2024-09-25T18:18:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/cache: join concurrent package batch operations\n\nOne of the unsolved problems of the gopls scalability redesign described\nat https://go.dev/blog/gopls-scalability is that concurrent type\nchecking operations may perform redundant work. While we avoided\nredundancy within the context of *one* operation, by encapsulating the\ntype checking batch, it is possible that there will be logically\ndistinct operations occurring concurrently, such as computing\ndiagnostics and autocompletion. These operations could not share type\ninformation, as they were operating within distinct type checking\n\"realms\" (recall that go/types relies on the canonicalization of\nimports).\n\nThis CL addresses that problem by refactoring the type checking batch\nsuch that it can join two distinct operations into a shared state. The\ntypeCheckBatch becomes a queryable entity, coordinating work across\nongoing package graph traversals.\n\nThis required surprisingly little change to the typeCheckBatch itself,\nwhich already abstracted the notion of a package traversal. Rather, the\nkey missing component was a future cache implementation that was (1)\nretryable and (2) transient, in the sense that computed values were\ndiscarded after use. The bulk of this change is the implementation and\ntesting of such a cache.\n\nSome elements of the refactoring remain awkward:\n\n- packageHandles are collected and merged into a shared map, because\n they must still be computed in large batches for efficiency.\n- the shared importGraph remains a clumsy optimization, requiring subtle\n logic to pre-build a shared import graph.\n\nMy intuition is that both of these problems have an elegant solution,\nbut this work is left for a subsequent CL.\n\nIn addition to reducing CPU across the board, due to less redundancy in\nthe existing diagnostic pass, this CL will facilitate the following\nadditions to gopls:\n\n- Pull-based diagnostics (golang/go#53275): now that diagnostic\n operations are naturally joined, there is less need for gopls to\n manage the scheduling of the diagnostic pass.\n- Improvements to loading behavior (golang/go#68002): being able to\n handle requests asynchronously allows completion requests to\n potentially be handled using stale metadata.\n\nUpdates golang/go#53275\nUpdates golang/go#68002\n\nChange-Id: Ib228cdcce2c4b6f616d6ba5b0abeb40e87f449be\nReviewed-on: https://go-review.googlesource.com/c/tools/+/611843\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/cache: join concurrent package batch operations"}},{"before":"d911e4a8841ec46f0daeb627659620228be57319","after":"34638fc6a41e9e7ec6ee99535ecb24a570b8f222","ref":"refs/heads/master","pushedAt":"2024-09-25T18:06:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/{callgraph,ssadump}, gopackages: make -tags flags work\n\nPreviously, the -tags flag used the obsolete buildutil.TagsFlag,\nwhich only affects the behavior of the obsolete go/loader.\nThis change causes the -tags flag to affect go/packages\nin these three tools, as it should.\n\nUpdates golang/go#69556\nUpdates golang/go#69538\n\nChange-Id: Ie45c51c7fe04863dba00bc2f81b0a78f1c9bd0e3\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614895\nTryBot-Bypass: Alan Donovan \nReviewed-by: Michael Matloob \nAuto-Submit: Alan Donovan \nCommit-Queue: Alan Donovan ","shortMessageHtmlLink":"cmd/{callgraph,ssadump}, gopackages: make -tags flags work"}},{"before":"eb774f69dce5beb64849eaf1800fcb6b31af2fb4","after":"d911e4a8841ec46f0daeb627659620228be57319","ref":"refs/heads/master","pushedAt":"2024-09-25T16:17:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls: disable ast.Object resolution wherever possible\n\nAnd where not, document why.\n\n(Locations were found by instrumenting parser.ParseFile\nand running gopls' tests.)\n\nChange-Id: Iab205b1f96b4fb4b22a5d056b40fbbb326dcd7a4\nReviewed-on: https://go-review.googlesource.com/c/tools/+/615436\nAuto-Submit: Alan Donovan \nTryBot-Bypass: Alan Donovan \nReviewed-by: Robert Findley \nCommit-Queue: Alan Donovan ","shortMessageHtmlLink":"gopls: disable ast.Object resolution wherever possible"}},{"before":"31fdc78e7d731b4dd2a4938a7a1911030cbc98c4","after":"eb774f69dce5beb64849eaf1800fcb6b31af2fb4","ref":"refs/heads/master","pushedAt":"2024-09-25T15:17:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/packages: fix LoadMode.String\n\nIt had neglected some newer entries.\nAlso, eliminate unnecessary tokens in the string.\n\nAlso, document the Load* mode bit sets.\nThey may be deprecated but they are useful, convenient,\nand widely used. Sometime remind me why they are deprecated.\n\nUpdates golang/go#69555\n\nChange-Id: Id0316cc1e9d39adf64e20db5194b867c3d19ab5d\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614875\nAuto-Submit: Alan Donovan \nCommit-Queue: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Matloob ","shortMessageHtmlLink":"go/packages: fix LoadMode.String"}},{"before":"752860b84edb34a684ef51f11ac68c3848ab5c22","after":"31fdc78e7d731b4dd2a4938a7a1911030cbc98c4","ref":"refs/heads/master","pushedAt":"2024-09-23T19:39:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/server: allow suppression of showDocument\n\nWhen calling `gopls.doc`, allow suppressing the showDocument call that opens the documentation link in the browser. Include the documentation link in the result.\n\nUpdates golang/go#55861\n\nChange-Id: I18fe3bddfbed1ef12934cb6c833fa0cf78260d04\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614300\nReviewed-by: Alan Donovan \nAuto-Submit: Alan Donovan \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/server: allow suppression of showDocument"}},{"before":"fadcea546d4a5b9f89351998c594e6f4933f4ac2","after":"752860b84edb34a684ef51f11ac68c3848ab5c22","ref":"refs/heads/master","pushedAt":"2024-09-23T18:23:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/protocol/command: simplify ApplyFix\n\n- combine URI + Range into one Location field\n- factor n calls addCommand(NewApplyFixCommand).\n\nChange-Id: I01c4ff7efeaa577331253348f4816a3a82b80db0\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614157\nCommit-Queue: Alan Donovan \nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/protocol/command: simplify ApplyFix"}},{"before":"f70550d233fd998bfdae39c066144b5bba81667c","after":"fadcea546d4a5b9f89351998c594e6f4933f4ac2","ref":"refs/heads/master","pushedAt":"2024-09-23T18:23:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: CodeAction: split into producers\n\nThis CL splits the ad hoc CodeAction function and its\nmany callees into a uniform list of \"producer\" functions,\neach responsible for a single CodeActionKind.\n\nEach producer is called only if its kind is enabled\nby the request, and any actions created by the producer\nautomatically have the appropriate kind.\n\nOnly producers that request type information will get it.\n\nTo avoid redundant computation when two producers need\nthe same information, the lazyInit mechanism allows\nthem to share common results, similar to sync.Once.\nFor example, quickFix and sourceOrganizeImports share\nthe results of a call to allImportsFixes.\n\nChange-Id: I4034970ed9b1e872d5c9bf4b085b98a121fa7144\nReviewed-on: https://go-review.googlesource.com/c/tools/+/612495\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/internal/golang: CodeAction: split into producers"}},{"before":"01bd772bc36e0e1c8246020fb2f0eb5ca4a2fc99","after":"f70550d233fd998bfdae39c066144b5bba81667c","ref":"refs/heads/master","pushedAt":"2024-09-23T18:11:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: migrate some tests in build_test.go away from loader\n\nFor golang/go#69556\n\nChange-Id: I9146de749112d046b9d27f012d2de25f9ff86382\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614955\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Alan Donovan \nReviewed-by: David Chase ","shortMessageHtmlLink":"go/ssa: migrate some tests in build_test.go away from loader"}},{"before":"af67b9d481011587692bd3e7cad85cc558a12016","after":"01bd772bc36e0e1c8246020fb2f0eb5ca4a2fc99","ref":"refs/heads/master","pushedAt":"2024-09-22T20:56:02.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/callgraph: rewrite tests to use go/packages not go/loader\n\nThe cha_test.loadPackages function has moved to testfiles.LoadPackages.\n\nUpdates golang/go#69556\n\nChange-Id: I5b1657388cb4d6ca435d1ab3a7cbf9cd264a0e7b\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614679\nReviewed-by: Tim King \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"go/callgraph: rewrite tests to use go/packages not go/loader"}},{"before":"3bb0ed7baac69031637d3456faa3d9e0a7220a9b","after":"af67b9d481011587692bd3e7cad85cc558a12016","ref":"refs/heads/master","pushedAt":"2024-09-20T21:40:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: migrate source_test.go away from loader\n\nAlso changes buildPackage to return a *packages.Package.\nbuildPackage no longer builds dependencies.\n\nFor golang/go#69556\n\nChange-Id: Id10ccee131394cda657213124907949a0b82f903\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614116\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"go/ssa: migrate source_test.go away from loader"}},{"before":"1d5e334177335fd58b8eee6f809b3589bf7371aa","after":"3bb0ed7baac69031637d3456faa3d9e0a7220a9b","ref":"refs/heads/master","pushedAt":"2024-09-20T21:11:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"x/tools: assume go1.22 and simplify\n\nThis CL does not include simplifications to gopls.\n\nUpdates golang/go#65917\nUpdates golang/go#69095\n\nChange-Id: I2b54992681e2c671324e22668d8401962a1d2363\nReviewed-on: https://go-review.googlesource.com/c/tools/+/593683\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"x/tools: assume go1.22 and simplify"}},{"before":"0b6abe39e040e4683b13225cbd7c47feca7dd489","after":"1d5e334177335fd58b8eee6f809b3589bf7371aa","ref":"refs/heads/master","pushedAt":"2024-09-20T19:51:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/aliases: remove Alias and Unalias\n\nThese two declarations can now safely be accessed directly\nfrom go/types.\n\nAlso, remove all mention of internal/aliases from gopls/...\nWe can enable two suppressed tests now that go1.23 is assured.\n\nUpdates golang/go#46477\n\nChange-Id: I9ae8536b0d022e3300b285547c18202bed302cf2\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614638\nLUCI-TryBot-Result: Go LUCI \nCommit-Queue: Tim King \nReviewed-by: Tim King ","shortMessageHtmlLink":"internal/aliases: remove Alias and Unalias"}},{"before":"6a0cacbfc0ee9b11a9e6a0aa715e236aee286a7c","after":"0b6abe39e040e4683b13225cbd7c47feca7dd489","ref":"refs/heads/master","pushedAt":"2024-09-20T19:40:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: remove loader utility functions\n\nRemoves the loader utility functions loadProgram and buildPackage.\nRenames buildContent to buildPackages.\n\nFor golang/go#69556\n\nChange-Id: I13b4f14d8d8aedaa3edbaa54d34a97cc2d56253f\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614717\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/ssa: remove loader utility functions"}},{"before":"1204c80e1c68f8823a1299ddcb31fb2348ad8c4d","after":"6a0cacbfc0ee9b11a9e6a0aa715e236aee286a7c","ref":"refs/heads/master","pushedAt":"2024-09-20T18:36:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: add test utility for building a single file\n\nAdds a new testing utility function that builds a module an\npackage from the contents of a single file. This allows for\nsignificant simplifications of the ssa tests. One benefit is\nremoving the use of the deprecated loader package.\n\nRefactors loadPackages to work from an fs.FS.\n\nFor golang/go#69556.\n\nChange-Id: If25f103982c82ea7945339e50f6c0e8576d276fa\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614735\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"go/ssa: add test utility for building a single file"}},{"before":"1c3716656e6ef45cdb3ff8c018856a44750165c4","after":"1204c80e1c68f8823a1299ddcb31fb2348ad8c4d","ref":"refs/heads/master","pushedAt":"2024-09-20T16:28:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/gorename: delete\n\nFixes golang/go#69360\n\nChange-Id: Ifea5e45eae670c45861fbc1f09ebe2872260b2e0\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614675\nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/gorename: delete"}},{"before":"dfc41b52638c0d750b565f7fa456eb605d3ef5dd","after":"1c3716656e6ef45cdb3ff8c018856a44750165c4","ref":"refs/heads/master","pushedAt":"2024-09-20T16:26:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: move build tag guarded tests\n\nMove tests out of files that have build tag guards that\nare now true for all supported versions.\n\nChange-Id: Ia8c5c8d20aa11991288a65eab72146adac60a82a\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614457\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/ssa: move build tag guarded tests"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yNlQyMTo1ODozMS4wMDAwMDBazwAAAATB_pAw","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMFQxNjoyNjo1MS4wMDAwMDBazwAAAAS8KyjU"}},"title":"Activity · golang/tools"}