Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/gotoolchain_issue66175 fails on tip locally [1.22 backport] #67311

Closed
gopherbot opened this issue May 10, 2024 · 2 comments
Closed

cmd/go: TestScript/gotoolchain_issue66175 fails on tip locally [1.22 backport] #67311

gopherbot opened this issue May 10, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22.4

Comments

@gopherbot
Copy link

@matloob requested issue #67277 to be considered for backport to the next 1.22 minor release.

@gopherbot Please backport to Go 1.21 and Go 1.22.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels May 10, 2024
@gopherbot gopherbot mentioned this issue May 10, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.4 milestone May 10, 2024
@matloob matloob added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 10, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/584955 mentions this issue: [release-branch.go1.22] cmd/go/testdata/script: clear path in gotoolchain_issue66175

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 10, 2024
@gopherbot
Copy link
Author

Closed by merging d4a81ec to release-branch.go1.22.

gopherbot pushed a commit that referenced this issue May 13, 2024
@matloob @gopherbot
[release-branch.go1.22] cmd/go/testdata/script: clear path in gotoolc…
d4a81ec 
…hain_issue66175

The gotoolchain_issue66175 script test would fail if a binary named
go1.21 or go1.22 was present in the system PATH. Clear the path at the
beginning of the test to make it independent of the system path.

For #67277
Fixes #67311

Change-Id: I6d9133aee5b20ab116e07b659e8ecf3eb8add4ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/584258
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
(cherry picked from commit a0a6026)
Reviewed-on: https://go-review.googlesource.com/c/go/+/584955
Auto-Submit: Dmitri Shuralyov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22.4
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @matloob