pgx not following intended import behaviour

[krishi-saripalli]

Describe the Bug
This is a follow up to issue #563

Despite following the guidlines about how to import drivers from database, I seem to be hitting the same problem with an unknown import error:

database driver: unknown driver pgx (forgotten import?)

I've also run the neccesary go get command with the pgx tag
go install -tags 'pgx' github.com/golang-migrate/migrate/v4/cmd/migrate@latest

"github.com/golang-migrate/migrate/v4"
	_ "github.com/golang-migrate/migrate/v4/database/pgx/v5"
	_ "github.com/golang-migrate/migrate/v4/source/file"
	
//more imports	
)


func main() {
	ctx := context.Background()
	port := ":8080" // Define the port as a variable for reuse
	lis, err := net.Listen("tcp", port)
	if err != nil {
		log.Fatalf("Failed to listen: %v", err)
	}
	//open db connection
	connStr := GetDbString()
	conn, err := pgx.Connect(ctx, connStr)
	if err != nil {
		log.Fatalf("Failed to connect to Postgres DB: %v", err)
	}
	log.Print("Successfully connected to %f", connStr)
	defer conn.Close(ctx)
	queries := db.New(conn)

	//Create server and register services
	grpcServer := grpc.NewServer()
	
	// Run migrations
	m, err := migrate.New(
		"file:///postgres/migrations",
		"pgx://test_db_user:test_db_password@db:5432/my_test_db")
	if err != nil {
		log.Fatalf("Migration creation failed: %v", err)  <------ failing here
	}
	if err := m.Up(); err != nil {
		if err != migrate.ErrNoChange {
			log.Fatalf("Migration failed: %v", err)
		}
	}
	log.Println("Migration completed successfully")

Steps to Reproduce
Steps to reproduce the behavior:

1. My migrations look like '...'
2. I ran migrate with the following options '....'
3. See error

Expected Behavior
I would expect a succesful migration

Loaded Database Drivers
pgx

Go Version
go 1.21 linux/amd64

[lao-tseu-is-alive]

I did have the same issue...
I found that because of --> https://github.com/golang-migrate/migrate/blob/master/database/pgx/v5/pgx.go#L30

You need to use pgx5 in your dsn like this :

m, err := migrate.New(
		"file:///postgres/migrations",
		"pgx5://test_db_user:test_db_password@db:5432/my_test_db")

hope it can help you or someone else

[levlozhkin]

Matching driver build tag, registration name and DSN/URL scheme worked for me:

Install, usage:

go install -tags 'pgx5' github.com/golang-migrate/migrate/v4/cmd/migrate
migrate -database="pgx5://postgres:hunter2@host:5432/db" -path=./migrations.d version

Aside: matching tool dependencies go.mod:

require (
  github.com/golang-migrate/migrate/v4 v4.17.1
  github.com/jackc/pgx/v5 v5.5.5
)

//go:build tools
package tools
import (
  _ "github.com/golang-migrate/migrate/v4"
  _ "github.com/golang-migrate/migrate/v4/database/pgx/v5"
  _ "github.com/jackc/pgx/v5"
)

Refs:

migrate/internal/cli/build_pgxv5.go

Line 1 in 2477f63

//go:build pgx5

migrate/database/pgx/v5/README.md

Line 5 in 2477f63

`pgx5://user:password@host:port/dbname?query`

migrate/database/pgx/v5/pgx.go

Line 30 in 2477f63

database.Register("pgx5", &db)