Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some config for server middleware trace for some special uri #2793

Open
ltp217 opened this issue Jul 21, 2023 · 3 comments
Open

add some config for server middleware trace for some special uri #2793

ltp217 opened this issue Jul 21, 2023 · 3 comments
Labels
feature help wanted planned This issue/proposal is planned into our next steps.

Comments

@ltp217
Copy link
Contributor

ltp217 commented Jul 21, 2023

1. What version of Go and system type/arch are you using?

go 1.19, linux/amd64

2. What version of GoFrame are you using?

goframe version v2.2.2

3. Can this issue be re-produced with the latest release?

yes, can re-produced in the latest release, v2.5.0

4. What did you do?

if we want to disable some uri to export trace, like the healthcheck, or the /metrics uri, how should we do, in the 'internalMiddlewareServerTracing' middleware, every uri will export its trace info. can add some config for this to avoid some uri that didn't need the trace info.

5. What did you expect to see?

disable some uri to export trace info, maybe we can add some config for this.

@hailaz hailaz added the feature label Aug 24, 2023
@gqcn gqcn added help wanted planned This issue/proposal is planned into our next steps. labels Sep 25, 2023
@github-actions
Copy link

Hello @ltp217. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!
你好 @ltp217。我们喜欢您的提案/反馈,并希望您或其他社区成员通过拉取请求做出贡献。我们提前感谢您的贡献,并期待对其进行审查。

@gqcn
Copy link
Member

gqcn commented Sep 25, 2023

@ltp217 It might be better to remove the tracing middleware from default enabled middleware.

@ltp217
Copy link
Contributor Author

ltp217 commented Oct 17, 2023

@gqcn it's greate influence when remove the default middleware, then just some special uri don't need the tracing info, like get metrics info or healthcheck. I think it's better to add some config for user to filter.

@github-actions github-actions bot removed the inactive label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted planned This issue/proposal is planned into our next steps.
Projects
None yet
Development

No branches or pull requests

3 participants