🩹 fix: Close File After SaveFileToStorage (#3197)

gopkg-dev · gaby · web-flow · commit 2c7bdb9fd14f · 2024-11-12T02:47:22.000+01:00
* fix: close file after opening in SaveFileToStorage to prevent resource leaks

* ♻️ refactor: simplify file close logic

* Update ctx.go

---------

Co-authored-by: Juan Calderon-Perez &lt;835733+gaby@users.noreply.github.com&gt;
diff --git a/ctx.go b/ctx.go
@@ -1470,6 +1470,7 @@ func (*DefaultCtx) SaveFileToStorage(fileheader *multipart.FileHeader, path stri
 	if err != nil {
 		return fmt.Errorf("failed to open: %w", err)
 	}
+	defer file.Close() //nolint:errcheck // not needed
 
 	content, err := io.ReadAll(file)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -1470,6 +1470,7 @@ func (DefaultCtx) SaveFileToStorage(fileheader multipart.FileHeader, path stri`
`1470`	`1470`	`if err != nil {`
`1471`	`1471`	`return fmt.Errorf("failed to open: %w", err)`
`1472`	`1472`	`}`
	`1473`	`+ defer file.Close() //nolint:errcheck // not needed`
`1473`	`1474`
`1474`	`1475`	`content, err := io.ReadAll(file)`
`1475`	`1476`	`if err != nil {`