Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown does not lock page scroll #277

Open
2 tasks
malmz opened this issue Apr 24, 2024 · 6 comments
Open
2 tasks

Dropdown does not lock page scroll #277

malmz opened this issue Apr 24, 2024 · 6 comments
Labels
blocked Blocked by upstream dependency bug Something isn't working

Comments

@malmz
Copy link

malmz commented Apr 24, 2024

Please provide the environment you discovered this bug in.

Dropdown example on spartan.ng components page

Which area/package is the issue in?

dropdown-menu

Description

When open, the dropdown does not lock scrolling on the page like radix-ui component does

Please provide the exception or error you saw

N/A

Other information

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@malek-itani
Copy link

malek-itani commented Apr 25, 2024

also as the menu gets open, trying to inspect Chrome dev tools leads to hiding the menu (using right click)

@goetzrobin goetzrobin added the blocked Blocked by upstream dependency label Apr 25, 2024
@goetzrobin
Copy link
Owner

I opened an issue in the Angular CDK repository. It's a limitation of their code. I lay out some more info here: angular/components#28965

@malek-itani
Copy link

Hi @goetzrobin I wondered what methodology or class Angular Material uses to block page scroll as mat-menu or mat-selects gets open, I tried inspecting HTML elements along with CSS props in Chrome dev tools, but unfortunately couldn't find anything helpful

@goetzrobin
Copy link
Owner

Screen.Recording.2024-04-25.at.4.27.35.PM_resized.mp4

Here you go

@malek-itani
Copy link

Screen.Recording.2024-04-25.at.4.27.35.PM_resized.mp4
Here you go

thank you so much, i appreciate it

@goetzrobin
Copy link
Owner

Upstream issue has been merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by upstream dependency bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants